[CSSTypedOM] Computed StylePropertyMap use ComputedStyle for Lengths

third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.h

 /*
  * Copyright (C) 2004 Zack Rusin <zack@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2008, 2012 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 48 matching lines @@
   const CSSValue* getPropertyCSSValue(AtomicString customPropertyName) const;
   std::unique_ptr<HashMap<AtomicString, RefPtr<CSSVariableData>>> getVariables()
       const;
 
   const CSSValue* getFontSizeCSSValuePreferringKeyword() const;
   bool isMonospaceFont() const;
 
   MutableStylePropertySet* copyPropertiesInSet(
       const Vector<CSSPropertyID>&) const;
 
+  // CSSOM functions.
+  unsigned length() const override;
+  String item(unsigned index) const override;
+  const CSSValue* getPropertyCSSValueInternal(
+      AtomicString customPropertyName) override;
+
   DECLARE_VIRTUAL_TRACE();
 
  private:
   CSSComputedStyleDeclaration(Node*, bool allowVisitedStyle, const String&);
 
   // The styled node is either the node passed into getComputedStyle, or the
   // PseudoElement for :before and :after if they exist.
   // FIXME: This should be styledElement since in JS getComputedStyle only works
   // on Elements, but right now editing creates these for text nodes. We should
   // fix that.
   Node* styledNode() const;
 
-  // CSSOM functions. Don't make these public.

[meade_UTC10, 2016/12/08 23:22:15]

Do you know why? :o

[meade_UTC10, 2017/01/05 03:43:45]

FWIW from code spelunking it looks like a long time ago (2012) some people at
apple were trying to split CSSStyleDeclaration and the CSSOM implementation as
part of making shareable stylesheet data structures
https://bugs.webkit.org/show_bug.cgi?id=77299, however that project seems to
have been abandoned. It's probably fine to make these public - it's weird that
the subclasses have a different API to the superclasses.

+  // CSSOM functions.
   CSSRule* parentRule() const override;
-  unsigned length() const override;
-  String item(unsigned index) const override;
   const ComputedStyle* computeComputedStyle() const;
   String getPropertyValue(const String& propertyName) override;
   String getPropertyPriority(const String& propertyName) override;
   String getPropertyShorthand(const String& propertyName) override;
   bool isPropertyImplicit(const String& propertyName) override;
   void setProperty(const String& propertyName,
                    const String& value,
                    const String& priority,
                    ExceptionState&) override;
   String removeProperty(const String& propertyName, ExceptionState&) override;
   String cssFloat() const;
   void setCSSFloat(const String&, ExceptionState&);
   String cssText() const override;
   void setCSSText(const String&, ExceptionState&) override;
   const CSSValue* getPropertyCSSValueInternal(CSSPropertyID) override;
-  const CSSValue* getPropertyCSSValueInternal(
-      AtomicString customPropertyName) override;
   String getPropertyValueInternal(CSSPropertyID) override;
   void setPropertyInternal(CSSPropertyID,
                            const String& customPropertyName,
                            const String& value,
                            bool important,
                            ExceptionState&) override;
 
   bool cssPropertyMatches(CSSPropertyID, const CSSValue*) const override;
 
   Member<Node> m_node;
   PseudoId m_pseudoElementSpecifier;
   bool m_allowVisitedStyle;
 };
 
 }  // namespace blink
 
 #endif  // CSSComputedStyleDeclaration_h