MD Settings: Stop calling chrome.settingsPrivate.setDefaultZoomLevel on startup.

chrome/browser/resources/settings/appearance_page/appearance_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * 'settings-appearance-page' is the settings page containing appearance
  * settings.
  *
  * Example:
  *
@@ skipping 16 matching lines @@
       type: Object,
       notify: true,
     },
 
     /** @private */
     useSystemTheme_: {
       type: Boolean,
       value: false,  // Can only be true on Linux, but value exists everywhere.
     },
 
-    /** @private */
-    defaultZoomLevel_: {
-      notify: true,
-      type: Object,
-      value: function() {
-        return {
-          type: chrome.settingsPrivate.PrefType.NUMBER,
-        };
-      },
-    },
-
     /**
      * List of options for the font size drop-down menu.
      * @type {!DropdownMenuOptionList}
      */
     fontSizeOptions_: {
       readOnly: true,
       type: Array,
       value: function() {
         return [
           {value: 9, name: loadTimeData.getString('verySmall')},
@@ skipping 46 matching lines @@
   /** @private {string} */
   themeUrl_: '',
 
   observers: [
     'themeChanged_(prefs.extensions.theme.id.value, useSystemTheme_)',
 
 <if expr="is_linux and not chromeos">
     // NOTE: this pref only exists on Linux.
     'useSystemThemePrefChanged_(prefs.extensions.theme.use_system.value)',
 </if>
-
-    'zoomLevelChanged_(defaultZoomLevel_.value)',
   ],
 
   created: function() {
     this.browserProxy_ = settings.AppearanceBrowserProxyImpl.getInstance();
   },
 
   ready: function() {
     this.$.defaultFontSize.menuOptions = this.fontSizeOptions_;
-    this.$.pageZoom.menuOptions = this.pageZoomOptions_;
     // TODO(dschuyler): Look into adding a listener for the
     // default zoom percent.
-    chrome.settingsPrivate.getDefaultZoomPercent(
-        this.zoomPrefChanged_.bind(this));
+    chrome.settingsPrivate.getDefaultZoomPercent(function(value) {
+      this.$.zoomLevel.value = value;

[Dan Beam, 2016/10/14 22:58:27]

this is all bonkers af

[dpapad, 2016/10/14 23:08:48]

Added a note with link to related bug.

+    }.bind(this));
   },
 
   /**
    * @param {boolean} isNtp Whether to use the NTP as the home page.
    * @param {string} homepage If not using NTP, use this URL.
    * @return {string} The sub-label.
    * @private
    */
   getShowHomeSubLabel_: function(isNtp, homepage) {
     if (isNtp)
@@ skipping 82 matching lines @@
 <if expr="is_linux and not chromeos">
     i18nId = useSystemTheme ? 'systemTheme' : 'classicTheme';
 </if>
 <if expr="not is_linux or chromeos">
     i18nId = 'chooseFromWebStore';
 </if>
     this.themeSublabel_ = this.i18n(i18nId);
     this.themeUrl_ = '';
   },
 
-  /**
-   * @param {number} percent The integer percentage of the page zoom.
-   * @private
-   */
-  zoomPrefChanged_: function(percent) {
-    this.set('defaultZoomLevel_.value', percent);
+  /** @private */
+  onZoomLevelChange_: function() {
+    chrome.settingsPrivate.setDefaultZoomPercent(
+        parseFloat(this.$.zoomLevel.value));
   },
 
   /**
-   * @param {number} percent The integer percentage of the page zoom.
-   * @private
-   */
-  zoomLevelChanged_: function(percent) {
-    // The |percent| may be undefined on startup.
-    if (percent === undefined)
-      return;
-    chrome.settingsPrivate.setDefaultZoomPercent(percent);
-  },
-
-  /**
    * @param {boolean} bookmarksBarVisible if bookmarks bar option is visible.
    * @return {string} 'first' if the argument is false or empty otherwise.
    * @private
    */
   getFirst_: function(bookmarksBarVisible) {
     return !bookmarksBarVisible ? 'first' : '';
   }
 });