Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2403303002: [d8] Fix LeakSanitizer failures on the bots due to ModuleEmbedderData (Closed)

Created:
4 years, 2 months ago by adamk
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[d8] Fix LeakSanitizer failures on the bots due to ModuleEmbedderData BUG=v8:1569 TBR=jochen@chromium.org Committed: https://crrev.com/cd6f1c98f989ef991da3ff465f183c1caa070918 Cr-Commit-Position: refs/heads/master@{#40143}

Patch Set 1 #

Patch Set 2 : Simplify #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M src/d8.cc View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
adamk
4 years, 2 months ago (2016-10-10 23:29:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2403303002/20001
4 years, 2 months ago (2016-10-10 23:30:10 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-10 23:53:18 UTC) #4
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/cd6f1c98f989ef991da3ff465f183c1caa070918 Cr-Commit-Position: refs/heads/master@{#40143}
4 years, 2 months ago (2016-10-10 23:53:38 UTC) #6
adamk
4 years, 2 months ago (2016-10-11 00:23:25 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2403103004/ by adamk@chromium.org.

The reason for reverting is: Still failing on auto-roll fyi bot.

Powered by Google App Engine
This is Rietveld 408576698