Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: dart/tools/testing/dart/browser_controller.dart

Issue 24033002: test.py: Bugfix in browser_controller. Make sure we always complete even in case of errors (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tools/testing/dart/browser_controller.dart
diff --git a/dart/tools/testing/dart/browser_controller.dart b/dart/tools/testing/dart/browser_controller.dart
index c6e07e7cb70a00b0900484dd32cb989828e5aab9..ecb082d1d928b467e5fbdd1336da25dfe580d15b 100644
--- a/dart/tools/testing/dart/browser_controller.dart
+++ b/dart/tools/testing/dart/browser_controller.dart
@@ -147,10 +147,9 @@ abstract class Browser {
if (_cleanup != null) {
_cleanup();
}
- doneCompleter.complete(true);
}).catchError((error) {
_logEvent("Error closing browsers: $error");
- });
+ }).whenComplete(() => doneCompleter.complete(true));
});
return true;
}).catchError((error) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698