Issue 240323004: Handlify function.prototype accessor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 240323004: Handlify function.prototype accessor. (Closed)

Created:
6 years, 8 months ago by ulan

Modified:
6 years, 8 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Handlify function.prototype accessor. BUG= R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20833

Patch Set 1 #

Total comments: 2

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -54 lines)			Patch
	M	src/accessors.cc	View		2 chunks	+67 lines, -54 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ulan

PTAL. I will convert the accessor to API-style accessor in the next cL.

6 years, 8 months ago (2014-04-16 15:26:29 UTC) #1

Yang

LGTM with nits. https://codereview.chromium.org/240323004/diff/1/src/accessors.cc File src/accessors.cc (right): https://codereview.chromium.org/240323004/diff/1/src/accessors.cc#newcode777 src/accessors.cc:777: Isolate* isolate) { I think the ...

6 years, 8 months ago (2014-04-17 05:55:41 UTC) #2

ulan

6 years, 8 months ago (2014-04-17 09:12:25 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r20833 (presubmit successful).

Expand Messages | Collapse Messages