Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: components/metrics/leak_detector/protobuf_to_mojo_converter_unittest.cc

Issue 2403223002: Leak reports collect information about the last uptrend (Closed)
Patch Set: Added a test case Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/leak_detector/protobuf_to_mojo_converter_unittest.cc
diff --git a/components/metrics/leak_detector/protobuf_to_mojo_converter_unittest.cc b/components/metrics/leak_detector/protobuf_to_mojo_converter_unittest.cc
index f768c312f05d42768b92597008f90203cd95c9af..2ba95a5c4143c61e0fc1305c31c26dcb5083b5ab 100644
--- a/components/metrics/leak_detector/protobuf_to_mojo_converter_unittest.cc
+++ b/components/metrics/leak_detector/protobuf_to_mojo_converter_unittest.cc
@@ -45,6 +45,8 @@ TEST(protobuf_to_mojo_converterTest, ConvertReport) {
report.add_call_stack(0xc001d00d);
report.add_call_stack(0x900df00d);
report.set_size_bytes(24);
+ report.set_num_rising_intervals(5);
+ report.set_num_allocs_increase(42);
auto entry1 = report.add_alloc_breakdown_history();
entry1->add_counts_by_size(1);
@@ -77,6 +79,8 @@ TEST(protobuf_to_mojo_converterTest, ConvertReport) {
EXPECT_EQ(0xc001d00d, mojo_report->call_stack[1]);
EXPECT_EQ(0x900df00d, mojo_report->call_stack[2]);
EXPECT_EQ(24U, mojo_report->size_bytes);
+ EXPECT_EQ(5U, mojo_report->num_rising_intervals);
+ EXPECT_EQ(42U, mojo_report->num_allocs_increase);
ASSERT_EQ(3U, mojo_report->alloc_breakdown_history.size());
@@ -110,6 +114,8 @@ TEST(protobuf_to_mojo_converterTest, ConvertReport) {
EXPECT_EQ(0xc001d00d, new_report.call_stack(1));
EXPECT_EQ(0x900df00d, new_report.call_stack(2));
EXPECT_EQ(24U, new_report.size_bytes());
+ EXPECT_EQ(5U, new_report.num_rising_intervals());
+ EXPECT_EQ(42U, new_report.num_allocs_increase());
ASSERT_EQ(3, new_report.alloc_breakdown_history().size());

Powered by Google App Engine
This is Rietveld 408576698