Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/metrics/proto/memory_leak_report.proto

Issue 2403223002: Leak reports collect information about the last uptrend (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/metrics/leak_detector/leak_detector_impl.cc ('K') | « components/metrics/leak_detector/protobuf_to_mojo_converter_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/proto/memory_leak_report.proto
diff --git a/components/metrics/proto/memory_leak_report.proto b/components/metrics/proto/memory_leak_report.proto
index 1a998fefa0b8a18bebf88cb4a5536e7421c10480..4994ca00b47f7f59617d22531e08c830e2beee76 100644
--- a/components/metrics/proto/memory_leak_report.proto
+++ b/components/metrics/proto/memory_leak_report.proto
@@ -109,7 +109,9 @@ message MemoryLeakReportProto {
//
// |num_rising_intervals| equals timeslot_now - timeslot_drop,
// where timeslot_drop is the timeslot number of the last frame that saw
- // a drop in the number of allocations (or 0 if there were no drops).
+ // a drop in the number of allocations, or the first frame in the history
+ // if there were no drops (history is cleared when the net number of
+ // allocations hit 0).
// If it is < 32, it will be visible in the allocation history graph.
// If it is >= 32, it will not be seen in the graph.
// E.g. for history [3,2,4,4,7] |num_rising_intervals| equals 3.
« components/metrics/leak_detector/leak_detector_impl.cc ('K') | « components/metrics/leak_detector/protobuf_to_mojo_converter_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698