Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: components/metrics/proto/memory_leak_report.proto

Issue 2403223002: Leak reports collect information about the last uptrend (Closed)
Patch Set: Added a test case Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/metrics/leak_detector/protobuf_to_mojo_converter_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 syntax = "proto2"; 5 syntax = "proto2";
6 6
7 option optimize_for = LITE_RUNTIME; 7 option optimize_for = LITE_RUNTIME;
8 8
9 package metrics; 9 package metrics;
10 10
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 // allocation. The oldest record is at the beginning. The most recent record, 102 // allocation. The oldest record is at the beginning. The most recent record,
103 // taken at the time the report was generated, is at the end. 103 // taken at the time the report was generated, is at the end.
104 repeated AllocationBreakdown alloc_breakdown_history = 4; 104 repeated AllocationBreakdown alloc_breakdown_history = 4;
105 105
106 // The following two fields describe the last increasing trend in the number 106 // The following two fields describe the last increasing trend in the number
107 // of allocations from the size and call stack that generated this 107 // of allocations from the size and call stack that generated this
108 // leak report. 108 // leak report.
109 // 109 //
110 // |num_rising_intervals| equals timeslot_now - timeslot_drop, 110 // |num_rising_intervals| equals timeslot_now - timeslot_drop,
111 // where timeslot_drop is the timeslot number of the last frame that saw 111 // where timeslot_drop is the timeslot number of the last frame that saw
112 // a drop in the number of allocations (or 0 if there were no drops). 112 // a drop in the number of allocations, or the first frame in the history
113 // if there were no drops (history is cleared when the net number of
114 // allocations hits 0).
Alexei Svitkine (slow) 2016/10/14 20:04:45 Please make this change in google3 first before la
Simon Que 2016/10/14 21:06:28 I am the host. I will take care of it in google3.
113 // If it is < 32, it will be visible in the allocation history graph. 115 // If it is < 32, it will be visible in the allocation history graph.
114 // If it is >= 32, it will not be seen in the graph. 116 // If it is >= 32, it will not be seen in the graph.
115 // E.g. for history [3,2,4,4,7] |num_rising_intervals| equals 3. 117 // E.g. for history [3,2,4,4,7] |num_rising_intervals| equals 3.
116 optional uint32 num_rising_intervals = 7; 118 optional uint32 num_rising_intervals = 7;
117 119
118 // Indicates the magnitude of the current uptrend in allocations. 120 // Indicates the magnitude of the current uptrend in allocations.
119 // E.g. for history [3,2,4,4,7] |num_allocs_increase| equals 5. 121 // E.g. for history [3,2,4,4,7] |num_allocs_increase| equals 5.
120 optional uint32 num_allocs_increase = 8; 122 optional uint32 num_allocs_increase = 8;
121 123
122 ////////////////////////////////////////////////////////////////////////////// 124 //////////////////////////////////////////////////////////////////////////////
123 125
124 // Contains additional data about the memory usage from the OS. 126 // Contains additional data about the memory usage from the OS.
125 // There is no need to store the total system memory as it is 127 // There is no need to store the total system memory as it is
126 // available under SystemProfileProto::Hardware::system_ram_mb. 128 // available under SystemProfileProto::Hardware::system_ram_mb.
127 // 129 //
128 // Next tag: 3 130 // Next tag: 3
129 message MemoryUsageInfo { 131 message MemoryUsageInfo {
130 // How much available physical memory the system has. 132 // How much available physical memory the system has.
131 optional uint64 available_ram_mb = 1; 133 optional uint64 available_ram_mb = 1;
132 134
133 // Total private working set memory across all Chrome processes. 135 // Total private working set memory across all Chrome processes.
134 optional uint64 chrome_ram_usage_mb = 2; 136 optional uint64 chrome_ram_usage_mb = 2;
135 } 137 }
136 138
137 // Information about the memory usage from the OS collected right after 139 // Information about the memory usage from the OS collected right after
138 // the leak report was created in the leak detector. 140 // the leak report was created in the leak detector.
139 optional MemoryUsageInfo memory_usage_info = 9; 141 optional MemoryUsageInfo memory_usage_info = 9;
140 } 142 }
OLDNEW
« no previous file with comments | « components/metrics/leak_detector/protobuf_to_mojo_converter_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698