Leak reports collect information about the last uptrend

components/metrics/leak_detector/leak_detector.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/metrics/leak_detector/leak_detector.h"
 
 #include <stdint.h>
 
 #include <algorithm>
 
@@ skipping 103 matching lines @@
   }
 
   for (const auto& entry : report.alloc_breakdown_history()) {
     auto* proto_entry = proto.add_alloc_breakdown_history();
     for (const uint32_t count : entry.counts_by_size) {
       proto_entry->add_counts_by_size(count);
     }
     proto_entry->set_count_for_call_stack(entry.count_for_call_stack);
   }
 
+  proto.set_num_rising_intervals(report.num_rising_intervals());
+  proto.set_num_allocs_increase(report.num_allocs_increase());
+
   return proto;
 }
 
 // The only instance of LeakDetector that should be used.
 base::LazyInstance<LeakDetector>::Leaky g_instance = LAZY_INSTANCE_INITIALIZER;
 
 // Thread-specific data to be used by hook functions.
 base::LazyInstance<base::ThreadLocalPointer<void>>::Leaky g_hook_data_tls =
     LAZY_INSTANCE_INITIALIZER;
 
@@ skipping 132 matching lines @@
 
     // Check for leaks after |analysis_interval_bytes_| bytes have been
     // allocated since the last time that was done.
     if (total_alloc_size >
         detector->last_analysis_alloc_size_ + analysis_interval_bytes) {
       // Try to maintain regular intervals of size |analysis_interval_bytes_|.
       detector->last_analysis_alloc_size_ =
           total_alloc_size - total_alloc_size % analysis_interval_bytes;
 
       InternalVector<InternalLeakReport> leak_reports;
-      detector->impl_->TestForLeaks(&leak_reports);
+      detector->impl_->TestForLeaks(&leak_reports, total_alloc_size);
+      for(auto &report : leak_reports)

[Simon Que, 2016/10/11 01:11:06]

Nit: space after "for"
Nit: "auto& report"

[mwlodar, 2016/10/11 07:13:24]

Done.

+        report.normalize_num_rising_intervals(analysis_interval_bytes);

[Simon Que, 2016/10/11 01:11:06]

Do the division here. See my comments in that function's definition.

[mwlodar, 2016/10/11 07:13:24]

Done.

 
       // Pass leak reports to observers.
       std::vector<MemoryLeakReportProto> leak_report_protos;
       leak_report_protos.reserve(leak_reports.size());
       std::transform(leak_reports.begin(), leak_reports.end(),
                      std::back_inserter(leak_report_protos),
                      &ConvertLeakReportToProto);
       detector->NotifyObservers(leak_report_protos);
     }
   }
@@ skipping 49 matching lines @@
     return;
   }
 
   {
     base::AutoLock lock(observers_lock_);
     FOR_EACH_OBSERVER(Observer, observers_, OnLeaksFound(reports));
   }
 }
 
 }  // namespace metrics