Leak reports collect information about the last uptrend

components/metrics/leak_detector/call_stack_table.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_METRICS_LEAK_DETECTOR_CALL_STACK_TABLE_H_
 #define COMPONENTS_METRICS_LEAK_DETECTOR_CALL_STACK_TABLE_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 30 matching lines @@
   void Remove(const CallStack* call_stack);
 
   // Check for leak patterns in the allocation data.
   void TestForLeaks();
 
   // Get the top N entries in the CallStackTable, ranked by net number of
   // allocations. N is given by |top_entries->max_size()|, so |*top_entries|
   // must already be initialized with that number.
   void GetTopCallStacks(RankedSet* top_entries) const;
 
+  // Updates fields in CallStackCountInfo for every stored call stack.

[Simon Que, 2016/10/11 01:11:05]

Explain the behavior in more detail. Mention e.g. when this function should be
called.

[mwlodar, 2016/10/11 07:13:23]

Done.

+  void UpdateLastDropInfo(size_t timestamp);
+
+  // Retrieves the number of timestamps and the count growth since the last

[Simon Que, 2016/10/11 01:11:05]

"number of timestamps" isn't quite right... did you mean "change in timestamp"?

[mwlodar, 2016/10/11 07:13:24]

Done.

+  // observed drop in the number for allocations for the given call stack.
+  void GetLastUptrendInfo(const CallStack* call_stack, size_t timestamp,
+                       size_t *timestamp_delta, uint32_t *count_delta) const;

[Simon Que, 2016/10/11 01:11:05]

Nit: alignment

[mwlodar, 2016/10/11 07:13:23]

Done.

+
   const LeakAnalyzer& leak_analyzer() const { return leak_analyzer_; }
 
   size_t size() const { return entry_map_.size(); }
   bool empty() const { return entry_map_.empty(); }
 
   uint32_t num_allocs() const { return num_allocs_; }
   uint32_t num_frees() const { return num_frees_; }
 
  private:
+  struct CallStackCountInfo {
+    uint32_t count, previous_count, last_drop_count;
+    size_t last_drop_timestamp;
+  };
+
   // Total number of allocs and frees in this table.
   uint32_t num_allocs_;
   uint32_t num_frees_;
 
   // Hash table containing entries. Uses CustomAllocator to avoid recursive
   // malloc hook invocation when analyzing allocs and frees.
   using TableEntryAllocator =
       STLAllocator<std::pair<const CallStack* const, uint32_t>,
                    CustomAllocator>;
 
   // Stores a mapping of each call stack to the number of recorded allocations
   // made from that call site.
   base::hash_map<const CallStack*,
-                 uint32_t,
+                 CallStackCountInfo,
                  StoredHash,
                  std::equal_to<const CallStack*>,
                  TableEntryAllocator> entry_map_;
 
   // For detecting leak patterns in incoming allocations.
   LeakAnalyzer leak_analyzer_;
 
   DISALLOW_COPY_AND_ASSIGN(CallStackTable);
 };
 
 }  // namespace leak_detector
 }  // namespace metrics
 
 #endif  // COMPONENTS_METRICS_LEAK_DETECTOR_CALL_STACK_TABLE_H_