Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2403163002: [promises] update comment about deferred reactions symbol state (Closed)

Created:
4 years, 2 months ago by gsathya
Modified:
4 years, 2 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[promises] update deferred reactions symbol The behavior was changed in https://codereview.chromium.org/2357423002 Committed: https://crrev.com/1f80f66de0240e70364da75a703b9a48c8a4d04e Cr-Commit-Position: refs/heads/master@{#40142}

Patch Set 1 #

Patch Set 2 : fix comment #

Total comments: 1

Patch Set 3 : rename #

Patch Set 4 : rename #

Patch Set 5 : fmt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -61 lines) Patch
M src/heap-symbols.h View 1 2 3 4 1 chunk +42 lines, -42 lines 0 comments Download
M src/js/promise.js View 1 2 6 chunks +14 lines, -19 lines 0 comments Download

Messages

Total messages: 28 (22 generated)
gsathya
4 years, 2 months ago (2016-10-10 19:13:08 UTC) #5
adamk
https://codereview.chromium.org/2403163002/diff/20001/src/js/promise.js File src/js/promise.js (right): https://codereview.chromium.org/2403163002/diff/20001/src/js/promise.js#newcode135 src/js/promise.js:135: SET_PRIVATE(promise, promiseDeferredReactionsSymbol, UNDEFINED); Can you rename the symbol to ...
4 years, 2 months ago (2016-10-10 19:19:32 UTC) #6
adamk
lgtm
4 years, 2 months ago (2016-10-10 22:28:31 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2403163002/80001
4 years, 2 months ago (2016-10-10 22:57:57 UTC) #25
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 2 months ago (2016-10-10 22:59:43 UTC) #26
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 22:59:59 UTC) #28
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/1f80f66de0240e70364da75a703b9a48c8a4d04e
Cr-Commit-Position: refs/heads/master@{#40142}

Powered by Google App Engine
This is Rietveld 408576698