|
|
Description[promises] update deferred reactions symbol
The behavior was changed in https://codereview.chromium.org/2357423002
Committed: https://crrev.com/1f80f66de0240e70364da75a703b9a48c8a4d04e
Cr-Commit-Position: refs/heads/master@{#40142}
Patch Set 1 #Patch Set 2 : fix comment #
Total comments: 1
Patch Set 3 : rename #Patch Set 4 : rename #Patch Set 5 : fmt #Messages
Total messages: 28 (22 generated)
The CQ bit was checked by gsathya@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [promises] update comment about deferred reactions symbol state The behavior was changed in https://codereview.chromium.org/2357423002 ========== to ========== [promises] update comment about deferred reactions symbol state The behavior was changed in https://codereview.chromium.org/2357423002 ==========
gsathya@chromium.org changed reviewers: + adamk@chromium.org
https://codereview.chromium.org/2403163002/diff/20001/src/js/promise.js File src/js/promise.js (right): https://codereview.chromium.org/2403163002/diff/20001/src/js/promise.js#newco... src/js/promise.js:135: SET_PRIVATE(promise, promiseDeferredReactionsSymbol, UNDEFINED); Can you rename the symbol to match its usage? And change the callers to stop using a plural for variables that are assigned the value of this symbol (I see "deferreds = ..." in several places)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [promises] update comment about deferred reactions symbol state The behavior was changed in https://codereview.chromium.org/2357423002 ========== to ========== [promises] update deferred reactions symbol The behavior was changed in https://codereview.chromium.org/2357423002 ==========
The CQ bit was checked by gsathya@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/26069)
The CQ bit was checked by gsathya@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/26072)
lgtm
The CQ bit was checked by gsathya@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by gsathya@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org Link to the patchset: https://codereview.chromium.org/2403163002/#ps80001 (title: "fmt")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== [promises] update deferred reactions symbol The behavior was changed in https://codereview.chromium.org/2357423002 ========== to ========== [promises] update deferred reactions symbol The behavior was changed in https://codereview.chromium.org/2357423002 Committed: https://crrev.com/1f80f66de0240e70364da75a703b9a48c8a4d04e Cr-Commit-Position: refs/heads/master@{#40142} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/1f80f66de0240e70364da75a703b9a48c8a4d04e Cr-Commit-Position: refs/heads/master@{#40142} |