Add method to convert an indirect object in a dictionary

Add method to convert to an indirect object in a dictionary.

Avoid an assert which previously could only be overcome
by removing/re-inserting.

Back-fill a unit test for the equivalent Array method.

BUG=654387
Committed: https://pdfium.googlesource.com/pdfium/+/381fc833ac9e6ea58762b7e7ac8b7f2129e8477f

[Tom Sepez, 2016-10-10 18:46:52]

Description was changed from

==========
Add method to force an indirect object in a dictionary'

BUG=654387
==========

to

==========
Add method to convert to an indirect object in a dictionary

BUG=654387
==========

[Tom Sepez, 2016-10-10 18:47:46]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 18:47:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 19:00:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 19:00:21]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-10-10 20:21:07]

Description was changed from

==========
Add method to convert to an indirect object in a dictionary

BUG=654387
==========

to

==========
Add method to convert to an indirect object in a dictionary.

Avoid an assert which previously could only be overcome
by removing/re-inserting.

Back-fill a unit test for the equivalent Array method.

BUG=654387
==========

[Tom Sepez, 2016-10-10 20:21:08]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-10-10 20:21:18]

Lei, for review

[Tom Sepez, 2016-10-10 20:21:22]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 20:21:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-10-10 20:23:59]

https://codereview.chromium.org/2403143002/diff/40001/fpdfsdk/fpdf_flatten.cpp
File fpdfsdk/fpdf_flatten.cpp (left):

https://codereview.chromium.org/2403143002/diff/40001/fpdfsdk/fpdf_flatten.cp...
fpdfsdk/fpdf_flatten.cpp:235: pPage->SetReferenceFor("Contents", pDocument,
Noted: Order of make unique, delete, insert here will trip assert when inserting
itself.

[commit-bot: I haz the power, 2016-10-10 20:36:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 20:36:24]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-10-10 20:48:26]

lgtm

https://codereview.chromium.org/2403143002/diff/40001/fpdfsdk/fpdf_flatten.cpp
File fpdfsdk/fpdf_flatten.cpp (right):

https://codereview.chromium.org/2403143002/diff/40001/fpdfsdk/fpdf_flatten.cp...
fpdfsdk/fpdf_flatten.cpp:197: void SetPageContents(CFX_ByteString key,
Pass by ref while we are here?

[Tom Sepez, 2016-10-10 20:51:45]

https://codereview.chromium.org/2403143002/diff/40001/fpdfsdk/fpdf_flatten.cpp
File fpdfsdk/fpdf_flatten.cpp (right):

https://codereview.chromium.org/2403143002/diff/40001/fpdfsdk/fpdf_flatten.cp...
fpdfsdk/fpdf_flatten.cpp:197: void SetPageContents(CFX_ByteString key,
On 2016/10/10 20:48:25, Lei Zhang wrote:
> Pass by ref while we are here?

Done.

[Tom Sepez, 2016-10-10 20:51:52]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-10-10 20:51:53]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2403143002/#ps60001
(title: "Const ref")

[commit-bot: I haz the power, 2016-10-10 20:52:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 21:06:47]

Description was changed from

==========
Add method to convert to an indirect object in a dictionary.

Avoid an assert which previously could only be overcome
by removing/re-inserting.

Back-fill a unit test for the equivalent Array method.

BUG=654387
==========

to

==========
Add method to convert to an indirect object in a dictionary.

Avoid an assert which previously could only be overcome
by removing/re-inserting.

Back-fill a unit test for the equivalent Array method.

BUG=654387

Committed:
https://pdfium.googlesource.com/pdfium/+/381fc833ac9e6ea58762b7e7ac8b7f2129e8...
==========

[commit-bot: I haz the power, 2016-10-10 21:06:48]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/381fc833ac9e6ea58762b7e7ac8b7f2129e8...