Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1528)

Issue 2403113002: Ignore svgRoot nodes. (Closed)

Created:
4 years, 2 months ago by David Tseng
Modified:
4 years, 2 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ignore svgRoot nodes. BUG=654233 TEST=manually verify read-all skips svg root CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/11f7d2835761708da719c5127564397b5c3b773f Cr-Commit-Position: refs/heads/master@{#424349}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
David Tseng
4 years, 2 months ago (2016-10-10 17:52:24 UTC) #4
dmazzoni
lgtm
4 years, 2 months ago (2016-10-10 19:37:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2403113002/1
4 years, 2 months ago (2016-10-11 01:49:23 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 02:43:05 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 02:45:05 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11f7d2835761708da719c5127564397b5c3b773f
Cr-Commit-Position: refs/heads/master@{#424349}

Powered by Google App Engine
This is Rietveld 408576698