Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Issue 2403103004: Revert of [d8] Fix LeakSanitizer failures on the bots due to ModuleEmbedderData (Closed)

Created:
4 years, 2 months ago by adamk
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [d8] Fix LeakSanitizer failures on the bots due to ModuleEmbedderData (patchset #2 id:20001 of https://codereview.chromium.org/2403303002/ ) Reason for revert: Still failing on auto-roll fyi bot Original issue's description: > [d8] Fix LeakSanitizer failures on the bots due to ModuleEmbedderData > > BUG=v8:1569 > TBR=jochen@chromium.org > > Committed: https://crrev.com/cd6f1c98f989ef991da3ff465f183c1caa070918 > Cr-Commit-Position: refs/heads/master@{#40143} TBR=jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:1569 Committed: https://crrev.com/9da6f1203fafeb3bb2675a7510efc981256755c9 Cr-Commit-Position: refs/heads/master@{#40144}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M src/d8.cc View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
adamk
Created Revert of [d8] Fix LeakSanitizer failures on the bots due to ModuleEmbedderData
4 years, 2 months ago (2016-10-11 00:23:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2403103004/1
4 years, 2 months ago (2016-10-11 00:23:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 00:23:49 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 00:24:14 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9da6f1203fafeb3bb2675a7510efc981256755c9
Cr-Commit-Position: refs/heads/master@{#40144}

Powered by Google App Engine
This is Rietveld 408576698