Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 2403103002: Specify the Android build number as a swarming dimension (Closed)

Created:
4 years, 2 months ago by borenet2
Modified:
4 years, 2 months ago
Reviewers:
kjlubick, borenet
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Specify the Android build number as a swarming dimension BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2403103002 Committed: https://skia.googlesource.com/skia/+/e17881889474270b39b03bd3def1ad4026548168

Patch Set 1 #

Total comments: 4

Patch Set 2 : Update N7, delete galaxy S3/S4 #

Messages

Total messages: 10 (4 generated)
borenet
4 years, 2 months ago (2016-10-10 16:50:25 UTC) #3
kjlubick
https://codereview.chromium.org/2403103002/diff/1/infra/bots/recipes/swarm_trigger.py File infra/bots/recipes/swarm_trigger.py (right): https://codereview.chromium.org/2403103002/diff/1/infra/bots/recipes/swarm_trigger.py#newcode125 infra/bots/recipes/swarm_trigger.py:125: 'GalaxyS3': ('m0', 'M'), Can't we remove the s3 and ...
4 years, 2 months ago (2016-10-10 16:52:50 UTC) #4
borenet
https://codereview.chromium.org/2403103002/diff/1/infra/bots/recipes/swarm_trigger.py File infra/bots/recipes/swarm_trigger.py (right): https://codereview.chromium.org/2403103002/diff/1/infra/bots/recipes/swarm_trigger.py#newcode125 infra/bots/recipes/swarm_trigger.py:125: 'GalaxyS3': ('m0', 'M'), On 2016/10/10 16:52:50, kjlubick wrote: > ...
4 years, 2 months ago (2016-10-10 16:56:57 UTC) #5
kjlubick
lgtm
4 years, 2 months ago (2016-10-10 16:58:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2403103002/20001
4 years, 2 months ago (2016-10-10 17:00:35 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 17:17:51 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e17881889474270b39b03bd3def1ad4026548168

Powered by Google App Engine
This is Rietveld 408576698