Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Unified Diff: pkg/polymer_expressions/lib/polymer_expressions.dart

Issue 24031006: Silently handle handle eval exceptions in PolymerExpressions (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/polymer_expressions/lib/polymer_expressions.dart
diff --git a/pkg/polymer_expressions/lib/polymer_expressions.dart b/pkg/polymer_expressions/lib/polymer_expressions.dart
index d74dacace4cad398796cc5cd7b18ae31ec54be1c..e7148ad98be8ebce9e7b83f23d109da3929588a1 100644
--- a/pkg/polymer_expressions/lib/polymer_expressions.dart
+++ b/pkg/polymer_expressions/lib/polymer_expressions.dart
@@ -16,7 +16,7 @@
* [Polymer.dart](http://www.dartlang.org/polymer-dart/)
* homepage for example code, project status, and
* information about how to get started using Polymer.dart in your apps.
- *
+ *
* ## Other resources
*
* The
@@ -31,11 +31,14 @@ import 'dart:async';
import 'dart:html';
import 'package:observe/observe.dart';
+import 'package:logging/logging.dart';
import 'eval.dart';
import 'expression.dart';
import 'parser.dart';
+final Logger _logger = new Logger('polymer_expressions');
+
// TODO(justin): Investigate XSS protection
Object _classAttributeConverter(v) =>
(v is Map) ? v.keys.where((k) => v[k] == true).join(' ') :
@@ -86,12 +89,18 @@ class _Binding extends Object with ChangeNotifierMixin {
final _converter;
var _value;
-
_Binding(Expression expr, Scope scope, [this._converter])
: _expr = observe(expr, scope),
_scope = scope {
- _expr.onUpdate.listen(_setValue);
- _setValue(_expr.currentValue);
+ _expr.onUpdate.listen(_setValue).onError((e) {
+ _logger.warning("Error evaluating expression '$_expr': ${e.message}");
+ });
+ try {
+ update(_expr, _scope);
+ _setValue(_expr.currentValue);
+ } on EvalException catch (e) {
+ _logger.warning("Error evaluating expression '$_expr': ${e.message}");
+ }
}
_setValue(v) {

Powered by Google App Engine
This is Rietveld 408576698