Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: src/ia32/assembler-ia32-inl.h

Issue 24031003: remove most uses of Isolate::Current in arch specific files (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 311 matching lines...) Expand 10 before | Expand all | Expand 10 after
322 } 322 }
323 323
324 324
325 Immediate::Immediate(Label* internal_offset) { 325 Immediate::Immediate(Label* internal_offset) {
326 x_ = reinterpret_cast<int32_t>(internal_offset); 326 x_ = reinterpret_cast<int32_t>(internal_offset);
327 rmode_ = RelocInfo::INTERNAL_REFERENCE; 327 rmode_ = RelocInfo::INTERNAL_REFERENCE;
328 } 328 }
329 329
330 330
331 Immediate::Immediate(Handle<Object> handle) { 331 Immediate::Immediate(Handle<Object> handle) {
332 #ifdef DEBUG
333 Isolate* isolate = Isolate::Current();
334 #endif
335 AllowDeferredHandleDereference using_raw_address; 332 AllowDeferredHandleDereference using_raw_address;
336 // Verify all Objects referred by code are NOT in new space. 333 // Verify all Objects referred by code are NOT in new space.
337 Object* obj = *handle; 334 Object* obj = *handle;
338 ASSERT(!isolate->heap()->InNewSpace(obj));
339 if (obj->IsHeapObject()) { 335 if (obj->IsHeapObject()) {
336 ASSERT(!HeapObject::cast(obj)->GetHeap()->InNewSpace(obj));
340 x_ = reinterpret_cast<intptr_t>(handle.location()); 337 x_ = reinterpret_cast<intptr_t>(handle.location());
341 rmode_ = RelocInfo::EMBEDDED_OBJECT; 338 rmode_ = RelocInfo::EMBEDDED_OBJECT;
342 } else { 339 } else {
343 // no relocation needed 340 // no relocation needed
344 x_ = reinterpret_cast<intptr_t>(obj); 341 x_ = reinterpret_cast<intptr_t>(obj);
345 rmode_ = RelocInfo::NONE32; 342 rmode_ = RelocInfo::NONE32;
346 } 343 }
347 } 344 }
348 345
349 346
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
519 516
520 Operand::Operand(int32_t disp, RelocInfo::Mode rmode) { 517 Operand::Operand(int32_t disp, RelocInfo::Mode rmode) {
521 // [disp/r] 518 // [disp/r]
522 set_modrm(0, ebp); 519 set_modrm(0, ebp);
523 set_dispr(disp, rmode); 520 set_dispr(disp, rmode);
524 } 521 }
525 522
526 } } // namespace v8::internal 523 } } // namespace v8::internal
527 524
528 #endif // V8_IA32_ASSEMBLER_IA32_INL_H_ 525 #endif // V8_IA32_ASSEMBLER_IA32_INL_H_
OLDNEW
« src/arm/code-stubs-arm.h ('K') | « src/code-stubs.cc ('k') | src/ia32/code-stubs-ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698