Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: test/cctest/wasm/wasm-run-utils.h

Issue 2403093002: [wasm] Canonicalize function signature indices for matching in indirect calls. (Closed)
Patch Set: Add TODO for myself Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/wasm/wasm-run-utils.h
diff --git a/test/cctest/wasm/wasm-run-utils.h b/test/cctest/wasm/wasm-run-utils.h
index 3a8b2278ec7e381fc6ea41544058e641130e56e0..1ba4872127049e12cf63ab431538a3e8b4bf031c 100644
--- a/test/cctest/wasm/wasm-run-utils.h
+++ b/test/cctest/wasm/wasm-run-utils.h
@@ -229,10 +229,13 @@ class TestingModule : public ModuleEnv {
}
void AddIndirectFunctionTable(uint16_t* functions, uint32_t table_size) {
- module_.function_tables.push_back(
- {table_size, table_size, std::vector<int32_t>(), false, false});
+ module_.function_tables.push_back({table_size, table_size,
+ std::vector<int32_t>(), false, false,
+ SignatureMap()});
+ WasmIndirectFunctionTable& table = module_.function_tables.back();
for (uint32_t i = 0; i < table_size; ++i) {
- module_.function_tables.back().values.push_back(functions[i]);
+ table.values.push_back(functions[i]);
+ table.map_.Get(module_.functions[functions[i]].sig);
}
Handle<FixedArray> values = BuildFunctionTable(

Powered by Google App Engine
This is Rietveld 408576698