Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 240303006: Docs: Remove unnecessary redirects from directories to 'index' files since we (Closed)

Created:
6 years, 8 months ago by not at google - send to devlin
Modified:
6 years, 8 months ago
Reviewers:
Jeffrey Yasskin, binji
CC:
chromium-reviews, binji+watch_chromium.org, chromium-apps-reviews_chromium.org, Sam Clegg, extensions-reviews_chromium.org
Visibility:
Public.

Description

Docs: Remove unnecessary redirects from directories to 'index' files since we now do that automatically. Fix a bug preventing the root directory from redirecting to 'index'. R=jyasskin@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264337

Patch Set 1 #

Patch Set 2 : . #

Total comments: 5

Patch Set 3 : move check up, remove nacl redirect #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -26 lines) Patch
M chrome/common/extensions/docs/server2/app.yaml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/content_provider.py View 1 2 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/server2/content_provider_test.py View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/server2/cron.yaml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/render_servlet.py View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/server2/render_servlet_test.py View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/templates/public/extensions/redirects.json View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/public/redirects.json View 1 2 1 chunk +2 lines, -7 lines 0 comments Download
D chrome/docs/redirects.json View 1 chunk +0 lines, -3 lines 0 comments Download
D native_client_sdk/doc_generated/redirects.json View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
not at google - send to devlin
https://codereview.chromium.org/240303006/diff/20001/chrome/common/extensions/docs/templates/public/redirects.json File chrome/common/extensions/docs/templates/public/redirects.json (right): https://codereview.chromium.org/240303006/diff/20001/chrome/common/extensions/docs/templates/public/redirects.json#newcode4 chrome/common/extensions/docs/templates/public/redirects.json:4: "native-client": "/native-client/overview" @binji -- this redirect doesn't actually work ...
6 years, 8 months ago (2014-04-16 22:28:10 UTC) #1
not at google - send to devlin
6 years, 8 months ago (2014-04-16 22:28:21 UTC) #2
not at google - send to devlin
binji for native_client_sdk/doc_generated/redirects.json and I also left you a comment in the CL.
6 years, 8 months ago (2014-04-16 22:28:40 UTC) #3
Jeffrey Yasskin
lgtm https://codereview.chromium.org/240303006/diff/20001/chrome/common/extensions/docs/server2/content_provider.py File chrome/common/extensions/docs/server2/content_provider.py (right): https://codereview.chromium.org/240303006/diff/20001/chrome/common/extensions/docs/server2/content_provider.py#newcode156 chrome/common/extensions/docs/server2/content_provider.py:156: # If a directory hasn't been rewritten to ...
6 years, 8 months ago (2014-04-16 22:44:08 UTC) #4
binji
native_client_sdk lgtm https://codereview.chromium.org/240303006/diff/20001/chrome/common/extensions/docs/templates/public/redirects.json File chrome/common/extensions/docs/templates/public/redirects.json (right): https://codereview.chromium.org/240303006/diff/20001/chrome/common/extensions/docs/templates/public/redirects.json#newcode4 chrome/common/extensions/docs/templates/public/redirects.json:4: "native-client": "/native-client/overview" On 2014/04/16 22:28:10, kalman wrote: ...
6 years, 8 months ago (2014-04-16 22:48:03 UTC) #5
not at google - send to devlin
https://codereview.chromium.org/240303006/diff/20001/chrome/common/extensions/docs/templates/public/redirects.json File chrome/common/extensions/docs/templates/public/redirects.json (right): https://codereview.chromium.org/240303006/diff/20001/chrome/common/extensions/docs/templates/public/redirects.json#newcode4 chrome/common/extensions/docs/templates/public/redirects.json:4: "native-client": "/native-client/overview" On 2014/04/16 22:48:03, binji wrote: > On ...
6 years, 8 months ago (2014-04-16 22:55:35 UTC) #6
not at google - send to devlin
https://codereview.chromium.org/240303006/diff/20001/chrome/common/extensions/docs/server2/content_provider.py File chrome/common/extensions/docs/server2/content_provider.py (right): https://codereview.chromium.org/240303006/diff/20001/chrome/common/extensions/docs/server2/content_provider.py#newcode156 chrome/common/extensions/docs/server2/content_provider.py:156: # If a directory hasn't been rewritten to an ...
6 years, 8 months ago (2014-04-16 23:03:23 UTC) #7
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 8 months ago (2014-04-16 23:03:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/240303006/40001
6 years, 8 months ago (2014-04-16 23:03:46 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-16 23:04:49 UTC) #10
Message was sent while issue was closed. 
Change committed as 264337

Powered by Google App Engine
This is Rietveld 408576698