Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1708)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java

Issue 2403023002: customtabs: Add a flag to mayLaunchUrl() to force prefetch. (Closed)
Patch Set: Accidentally a chunk. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
index b2f398d312dedb2b1b04c81ce5050ff83244c0f9..24dd2624a07ab6446205b79e0af9572e4bf91a4a 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
@@ -860,7 +860,8 @@ public class CustomTabActivityTest extends CustomTabActivityTestBase {
CustomTabsSessionToken token = CustomTabsSessionToken.getSessionTokenFromIntent(intent);
assertTrue(connection.newSession(token));
Bundle extras = new Bundle();
- extras.putBoolean(CustomTabsConnection.NO_PRERENDERING_KEY, true);
+ extras.putInt(
+ CustomTabsConnection.DEBUG_OVERRIDE_KEY, CustomTabsConnection.NO_PRERENDERING);
assertTrue(connection.mayLaunchUrl(token, Uri.parse(mTestPage), extras, null));
try {
startCustomTabActivityWithIntent(intent);
@@ -1330,7 +1331,8 @@ public class CustomTabActivityTest extends CustomTabActivityTestBase {
Bundle extras = null;
if (noPrerendering) {
extras = new Bundle();
- extras.putBoolean(CustomTabsConnection.NO_PRERENDERING_KEY, true);
+ extras.putInt(
+ CustomTabsConnection.DEBUG_OVERRIDE_KEY, CustomTabsConnection.NO_PRERENDERING);
}
assertTrue(connection.mayLaunchUrl(token, Uri.parse(mTestPage), extras, null));
try {
@@ -1448,10 +1450,11 @@ public class CustomTabActivityTest extends CustomTabActivityTestBase {
CriteriaHelper.pollUiThread(new Criteria("No Prerender") {
@Override
public boolean isSatisfied() {
- return connection.mPrerender != null && connection.mPrerender.mWebContents != null
+ return connection.mSpeculation != null
+ && connection.mSpeculation.webContents != null
&& ExternalPrerenderHandler.hasPrerenderedAndFinishedLoadingUrl(
Profile.getLastUsedProfile(), url,
- connection.mPrerender.mWebContents);
+ connection.mSpeculation.webContents);
}
});
}

Powered by Google App Engine
This is Rietveld 408576698