Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: src/crankshaft/hydrogen.h

Issue 2403003002: Speedup access to global_proxy.* attributes/accessors. (Closed)
Patch Set: Check for nullptr return in InlineGlobalPropertyStore. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/crankshaft/hydrogen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/crankshaft/hydrogen.h
diff --git a/src/crankshaft/hydrogen.h b/src/crankshaft/hydrogen.h
index 649047e896e22d5443124a4cfc98d2385e90c923..fbcfbd53d94bdcea463646fbb802e4b68ae0ebf9 100644
--- a/src/crankshaft/hydrogen.h
+++ b/src/crankshaft/hydrogen.h
@@ -2333,13 +2333,15 @@ class HOptimizedGraphBuilder : public HGraphBuilder,
#undef DECLARE_VISIT
private:
- // Helpers for flow graph construction.
- enum GlobalPropertyAccess {
- kUseCell,
- kUseGeneric
- };
- GlobalPropertyAccess LookupGlobalProperty(Variable* var, LookupIterator* it,
- PropertyAccessType access_type);
+ bool CanInlineGlobalPropertyAccess(Variable* var, LookupIterator* it,
+ PropertyAccessType access_type);
+
+ bool CanInlineGlobalPropertyAccess(LookupIterator* it,
+ PropertyAccessType access_type);
+
+ void InlineGlobalPropertyLoad(LookupIterator* it, BailoutId ast_id);
+ HInstruction* InlineGlobalPropertyStore(LookupIterator* it, HValue* value,
+ BailoutId ast_id);
void EnsureArgumentsArePushedForAccess();
bool TryArgumentsAccess(Property* expr);
« no previous file with comments | « no previous file | src/crankshaft/hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698