Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: src/crankshaft/hydrogen.h

Issue 2403003002: Speedup access to global_proxy.* attributes/accessors. (Closed)
Patch Set: Fix issue that led to revert. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/crankshaft/hydrogen.cc » ('j') | src/crankshaft/hydrogen.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/crankshaft/hydrogen.h
diff --git a/src/crankshaft/hydrogen.h b/src/crankshaft/hydrogen.h
index d2f1637d113a250eead2d6d096bac29cd849cdfe..320f1e2b0482c4dddceb10a3686d3bb102bee214 100644
--- a/src/crankshaft/hydrogen.h
+++ b/src/crankshaft/hydrogen.h
@@ -2364,13 +2364,15 @@ class HOptimizedGraphBuilder : public HGraphBuilder,
#undef DECLARE_VISIT
private:
- // Helpers for flow graph construction.
- enum GlobalPropertyAccess {
- kUseCell,
- kUseGeneric
- };
- GlobalPropertyAccess LookupGlobalProperty(Variable* var, LookupIterator* it,
- PropertyAccessType access_type);
+ bool CanInlineGlobalPropertyAccess(Variable* var, LookupIterator* it,
+ PropertyAccessType access_type);
+
+ bool CanInlineGlobalPropertyAccess(LookupIterator* it,
+ PropertyAccessType access_type);
+
+ void InlineGlobalPropertyLoad(LookupIterator* it, BailoutId ast_id);
+ void InlineGlobalPropertyStore(LookupIterator* it, HValue* value,
+ BailoutId ast_id);
void EnsureArgumentsArePushedForAccess();
bool TryArgumentsAccess(Property* expr);
« no previous file with comments | « no previous file | src/crankshaft/hydrogen.cc » ('j') | src/crankshaft/hydrogen.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698