Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: third_party/WebKit/Source/modules/ModulesInitializer.cpp

Issue 2402983002: [TimeZoneMonitor] Decouple renderer side impl from content to blink. (Closed)
Patch Set: Remove TimeZoneMonitorClient::Bind() Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/ModulesInitializer.cpp
diff --git a/third_party/WebKit/Source/modules/ModulesInitializer.cpp b/third_party/WebKit/Source/modules/ModulesInitializer.cpp
index 6eddf4552ef24ef5d4e10b435cd65e07bca9fdf7..955dfa4d88c964bae53571e4d6c464e146b91bee 100644
--- a/third_party/WebKit/Source/modules/ModulesInitializer.cpp
+++ b/third_party/WebKit/Source/modules/ModulesInitializer.cpp
@@ -21,6 +21,7 @@
#include "modules/filesystem/DraggedIsolatedFileSystemImpl.h"
#include "modules/imagebitmap/ImageBitmapRenderingContext.h"
#include "modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h"
+#include "modules/time_zone_monitor/TimeZoneMonitorClient.h"
#include "modules/webdatabase/DatabaseManager.h"
#include "modules/webgl/WebGL2RenderingContext.h"
#include "modules/webgl/WebGLRenderingContext.h"
@@ -47,6 +48,11 @@ void ModulesInitializer::initialize() {
DraggedIsolatedFileSystem::init(
DraggedIsolatedFileSystemImpl::prepareForDataObject);
CSSPaintImageGenerator::init(CSSPaintImageGeneratorImpl::create);
+ // Some unit tests may have no message loop ready, so we can't initialize the
+ // mojo stuff here. They can initialize those mojo stuff they're interested in
+ // later after they got a message loop ready.
+ if (Platform::isMessageLoopReady())
kinuko 2016/11/08 03:22:56 Huh this is sad :( (and read all the threads about
+ TimeZoneMonitorClient::Init();
CoreInitializer::initialize();

Powered by Google App Engine
This is Rietveld 408576698