Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: content/renderer/render_thread_impl.cc

Issue 2402983002: [TimeZoneMonitor] Decouple renderer side impl from content to blink. (Closed)
Patch Set: Rebase only Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_thread_impl.cc
diff --git a/content/renderer/render_thread_impl.cc b/content/renderer/render_thread_impl.cc
index cd415a0e6a122b2a6c5d8bb6098d86b10f045928..bdb55602e99090dae5bd0187339cdb124a2532c8 100644
--- a/content/renderer/render_thread_impl.cc
+++ b/content/renderer/render_thread_impl.cc
@@ -160,7 +160,6 @@
#include "third_party/WebKit/public/web/WebScriptController.h"
#include "third_party/WebKit/public/web/WebSecurityPolicy.h"
#include "third_party/WebKit/public/web/WebView.h"
-#include "third_party/icu/source/i18n/unicode/timezone.h"
#include "third_party/skia/include/core/SkGraphics.h"
#include "ui/base/layout.h"
#include "ui/base/ui_base_switches.h"
@@ -324,13 +323,6 @@ void AddHistogramSample(void* hist, int sample) {
histogram->Add(sample);
}
-void NotifyTimezoneChangeOnThisThread() {
- v8::Isolate* isolate = v8::Isolate::GetCurrent();
- if (!isolate)
- return;
- v8::Date::DateTimeConfigurationChangeNotification(isolate);
-}
-
class FrameFactoryImpl : public mojom::FrameFactory {
public:
FrameFactoryImpl() : routing_id_highmark_(-1) {}
@@ -604,7 +596,6 @@ RenderThreadImpl::RenderThreadImpl(
.ConnectToBrowser(true)
.Build()),
renderer_scheduler_(std::move(scheduler)),
- time_zone_monitor_binding_(this),
categorized_worker_pool_(new CategorizedWorkerPool()),
renderer_binding_(this) {
Init(resource_task_queue);
@@ -620,7 +611,6 @@ RenderThreadImpl::RenderThreadImpl(
.ConnectToBrowser(true)
.Build()),
renderer_scheduler_(std::move(scheduler)),
- time_zone_monitor_binding_(this),
main_message_loop_(std::move(main_message_loop)),
categorized_worker_pool_(new CategorizedWorkerPool()),
renderer_binding_(this) {
@@ -883,11 +873,6 @@ void RenderThreadImpl::Init(
GetRemoteInterfaces()->GetInterface(
mojo::GetProxy(&storage_partition_service_));
- device::mojom::TimeZoneMonitorPtr time_zone_monitor;
- GetRemoteInterfaces()->GetInterface(mojo::GetProxy(&time_zone_monitor));
- time_zone_monitor->AddClient(
- time_zone_monitor_binding_.CreateInterfacePtrAndBind());
-
#if defined(OS_LINUX)
ChildProcess::current()->SetIOThreadPriority(base::ThreadPriority::DISPLAY);
ChildThreadImpl::current()->SetThreadPriority(
@@ -1336,12 +1321,6 @@ void RenderThreadImpl::RegisterSchemes() {
WebSecurityPolicy::registerURLSchemeAsDisplayIsolated(view_source_scheme);
}
-void RenderThreadImpl::NotifyTimezoneChange() {
- NotifyTimezoneChangeOnThisThread();
- RenderThread::Get()->PostTaskToAllWebWorkers(
- base::Bind(&NotifyTimezoneChangeOnThisThread));
-}
-
void RenderThreadImpl::RecordAction(const base::UserMetricsAction& action) {
Send(new ViewHostMsg_UserMetricsRecordAction(action.str_));
}
@@ -2075,18 +2054,6 @@ void RenderThreadImpl::CreateFrameProxy(
replicated_state);
}
-void RenderThreadImpl::OnTimeZoneChange(const std::string& zone_id) {
- if (!blink_platform_impl_)
- return;
- if (!zone_id.empty()) {
- icu::TimeZone *new_zone = icu::TimeZone::createTimeZone(
- icu::UnicodeString::fromUTF8(zone_id));
- icu::TimeZone::adoptDefault(new_zone);
- VLOG(1) << "ICU default timezone is set to " << zone_id;
- }
- NotifyTimezoneChange();
-}
-
#if defined(OS_ANDROID)
void RenderThreadImpl::OnSetWebKitSharedTimersSuspended(bool suspend) {
if (suspend) {

Powered by Google App Engine
This is Rietveld 408576698