Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2402963002: [sensors] Fix crash when nullptr instead of a pointer to sensor is sent (Closed)

Created:
4 years, 2 months ago by maksims (do not use this acc)
Modified:
4 years, 2 months ago
Reviewers:
Mikhail
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sensors] Fix crash when nullptr instead of a pointer to sensor is sent Send mojom::SensorClientRequest to NotifySensorCreated in order to avoid crash when sensor is nullptr. BUG=606766 Committed: https://crrev.com/46db493d716421b1bf468d7b29bd61eedfdd32fb Cr-Commit-Position: refs/heads/master@{#424129}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M device/generic_sensor/sensor_provider_impl.cc View 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
maksims (do not use this acc)
please check
4 years, 2 months ago (2016-10-10 10:05:10 UTC) #2
Mikhail
lgtm
4 years, 2 months ago (2016-10-10 10:08:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2402963002/1
4 years, 2 months ago (2016-10-10 10:17:48 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-10 10:59:25 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 11:01:00 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46db493d716421b1bf468d7b29bd61eedfdd32fb
Cr-Commit-Position: refs/heads/master@{#424129}

Powered by Google App Engine
This is Rietveld 408576698