Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4531)

Unified Diff: chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.h

Issue 2402903002: Make the timing of ManifestUpgradeDetectorFetcher::Start() call less subtle (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.h
diff --git a/chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.h b/chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.h
index faac56481cef4b4d53d87a94bf17489c0dd26b52..6f090a846f13bfacdfe313a69a7cb39b0f15c19d 100644
--- a/chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.h
+++ b/chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.h
@@ -53,8 +53,10 @@ class ManifestUpgradeDetectorFetcher : public content::WebContentsObserver {
~ManifestUpgradeDetectorFetcher() override;
// content::WebContentsObserver:
- void DidFinishLoad(content::RenderFrameHost* render_frame_host,
- const GURL& validated_url) override;
+ void DidStopLoading() override;
+
+ // Fetches the installable data.
+ void FetchInstallableData();
// Called once the installable data has been fetched.
void OnDidGetInstallableData(const InstallableData& installable_data);
@@ -75,6 +77,9 @@ class ManifestUpgradeDetectorFetcher : public content::WebContentsObserver {
// The WebAPK's Web Manifest URL that the detector is looking for.
const GURL web_manifest_url_;
+ // The URL for which the installable data is being fetched / was last fetched.
+ GURL last_fetched_url_;
+
// Downloads app icon and computes Murmur2 hash.
std::unique_ptr<WebApkIconHasher> icon_hasher_;
« no previous file with comments | « no previous file | chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698