Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1307)

Issue 2402883003: Removes usage of hardware AGC and any related APIs on Android (Closed)

Created:
4 years, 2 months ago by henrika_webrtc
Modified:
4 years, 2 months ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org, peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removes usage of hardware AGC and any related APIs on Android. Compromise solution where WebRtcAudioUtils.setWebRtcBasedAutomaticGainControl() is marked as deprecated and where as many APIs as possible that touches the HW AGC are removed. Some basic architecture is saved to ensure that we can restore usage of the HW AGC if ever required for future devices. The AppRTCMobile demo does still contain an AGC check box but it is now grayed out. BUG=b/30387905 Committed: https://crrev.com/defc21e0aa6b090111d6bd8ffe43ddafcb657c7d Cr-Commit-Position: refs/heads/master@{#14596}

Patch Set 1 #

Messages

Total messages: 12 (7 generated)
henrika_webrtc
Alex, as discussed. I kept some JNI-related parts just in case but removed or hard-coded ...
4 years, 2 months ago (2016-10-10 13:33:28 UTC) #5
AlexG
lgtm
4 years, 2 months ago (2016-10-10 18:20:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2402883003/1
4 years, 2 months ago (2016-10-11 08:03:13 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 08:29:12 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 08:29:24 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/defc21e0aa6b090111d6bd8ffe43ddafcb657c7d
Cr-Commit-Position: refs/heads/master@{#14596}

Powered by Google App Engine
This is Rietveld 408576698