Add check for file:-navigations from PDFs

chrome/test/data/pdf/navigator_test.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 function MockNavigatorDelegate() {
   this.navigateInCurrentTabCalled = false;
   this.navigateInNewTabCalled = false;
   this.navigateInNewWindowCalled = false;
   this.url = undefined;
 }
 
 MockNavigatorDelegate.prototype = {
   navigateInCurrentTab: function(url) {
     this.navigateInCurrentTabCalled = true;
-    this.url = url;
+    this.url = url || '<called, but no url set>';
   },
   navigateInNewTab: function(url) {
     this.navigateInNewTabCalled = true;
-    this.url = url;
+    this.url = url || '<called, but no url set>';
 
   },
   navigateInNewWindow: function(url) {
     this.navigateInNewWindowCalled = true;
-    this.url = url;
+    this.url = url || '<called, but no url set>';
   },
   reset: function() {
     this.navigateInCurrentTabCalled = false;
     this.navigateInNewTabCalled = false;
     this.navigateInNewWindowCalled = false;
     this.url = undefined;
   }
 }
 
 /**
  * Given a |navigator|, navigate to |url| in the current tab, a new tab, or
  * a new window depending on the value of |disposition|. Use
  * |viewportChangedCallback| and |navigatorDelegate| to check the callbacks,
  * and that the navigation to |expectedResultUrl| happened.
  */
 function doNavigationUrlTest(
     navigator,
     url,
     disposition,
     expectedResultUrl,
     viewportChangedCallback,
     navigatorDelegate) {
   viewportChangedCallback.reset();
   navigatorDelegate.reset();
   navigator.navigate(url, disposition);
   chrome.test.assertFalse(viewportChangedCallback.wasCalled);
+  chrome.test.assertEq(expectedResultUrl, navigatorDelegate.url);
+  if (expectedResultUrl === undefined) {
+    return;

[raymes, 2016/10/13 00:11:34]

Can we assert 
navigatorDelegate.navigateInCurrentTabCalled
navigatorDelegate.navigateInNewTabCalled
navigatorDelegate.navigateInNewWindowCalled

are all false in this case?

[robwu, 2016/10/13 07:22:35]

That is not needed, because url is undefined iff there is no navigation.
That is also why I modified the delegate above to include a default value for
url.

+  }
   switch (disposition) {
     case Navigator.WindowOpenDisposition.CURRENT_TAB:
       chrome.test.assertTrue(navigatorDelegate.navigateInCurrentTabCalled);
       break;
     case Navigator.WindowOpenDisposition.NEW_BACKGROUND_TAB:
       chrome.test.assertTrue(navigatorDelegate.navigateInNewTabCalled);
       break;
     case Navigator.WindowOpenDisposition.NEW_WINDOW:
       chrome.test.assertTrue(navigatorDelegate.navigateInNewWindowCalled);
       break;
     default:
       break;
   }
-  chrome.test.assertEq(expectedResultUrl, navigatorDelegate.url);
 }
 
 /**
  * Helper function to run doNavigationUrlTest() for the current tab, a new
  * tab, and a new window.
  */
 function doNavigationUrlTests(originalUrl, url, expectedResultUrl) {
   var mockWindow = new MockWindow(100, 100);
   var mockSizer = new MockSizer();
   var mockViewportChangedCallback = new MockViewportChangedCallback();
@@ skipping 171 matching lines @@
   function testNavigateFromLocalFile() {
     var url = "file:///some/path/to/myfile.pdf";
 
     // Open an absolute link.
     doNavigationUrlTests(
         url,
         '/foodotcom/bar.pdf',
         'file:///foodotcom/bar.pdf');
 
     chrome.test.succeed();
+  },
+
+  function testNavigateInvalidUrls() {
+    var url = 'https://example.com/some-web-document.pdf';
+
+    // From non-file: to file:
+    doNavigationUrlTests(
+        url,
+        'file:///bar.pdf',
+        undefined);
+
+    doNavigationUrlTests(
+        url,
+        'chrome://version',
+        undefined);
+
+    doNavigationUrlTests(
+        url,
+        'javascript:// this is not a document.pdf',
+        undefined);
+
+    doNavigationUrlTests(
+        url,
+        'this-is-not-a-valid-scheme://path.pdf',
+        undefined);
+
+    doNavigationUrlTests(
+        url,
+        '',
+        undefined);
+
+    chrome.test.succeed();
   }
 ];
 
 var scriptingAPI = new PDFScriptingAPI(window, window);
 scriptingAPI.setLoadCallback(function() {
   chrome.test.runTests(tests);
 });