Add check for file:-navigations from PDFs

chrome/browser/resources/pdf/navigator.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * Creates a new NavigatorDelegate for calling browser-specific functions to
  * do the actual navigating.
  * @param {boolean} isInTab Indicates if the PDF viewer is displayed in a tab.
@@ skipping 36 matching lines @@
       window.location.href = url;
   },
 
   /**
    * @public
    * Called when navigation should happen in the new tab.
    * @param {string} url The url to be opened in the new tab.
    * @param {boolean} active Indicates if the new tab should be the active tab.
    */
   navigateInNewTab: function(url, active) {
+    if (!this.isSourceFileUrl_ && /^file:/i.test(url))
+      return;
+
     // Prefer the tabs API because it guarantees we can just open a new tab.
     // window.open doesn't have this guarantee.
     if (chrome.tabs)
       chrome.tabs.create({url: url, active: active});
     else
       window.open(url);
   },
 
   /**
    * @public
    * Called when navigation should happen in the new window.
    * @param {string} url The url to be opened in the new window.
    */
   navigateInNewWindow: function(url) {
+    if (!this.isSourceFileUrl_ && /^file:/i.test(url))

[Lei Zhang, 2016/10/10 21:07:04]

Can we write a helper function and call it from multiple places? Should
navigateInCurrentTab() call it as well?

[raymes, 2016/10/11 06:37:42]

+1

Could you also please add a test to this to navigator_test.js. We may also want
a test in pdf_extension_test.cc

[robwu, 2016/10/12 22:08:01]

Done.

+      return;
+
     // Prefer the windows API because it guarantees we can just open a new
     // window. window.open with '_blank' argument doesn't have this guarantee.
     if (chrome.windows)
       chrome.windows.create({url: url});
     else
       window.open(url, '_blank');
   }
 };
 
 /**
@@ skipping 169 matching lines @@
     if (isRelative) {
       var slashIndex = this.originalUrl_.lastIndexOf('/');
       var path = slashIndex != -1 ?
           this.originalUrl_.substr(0, slashIndex) : this.originalUrl_;
       return path + '/' + url;
     }
 
     return 'http://' + url;
   }
 };