Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: LayoutTests/fast/encoding/api/end-of-file.html

Issue 240283013: Convert Encoding API tests to W3C testharness.js (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Move UTF-16 surrogate tests to separate file Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/encoding/api/end-of-file.html
diff --git a/LayoutTests/fast/encoding/api/end-of-file.html b/LayoutTests/fast/encoding/api/end-of-file.html
index 0e9615b23eed70fb98374ed2f4d876df768ec368..038d2080b85c71929fe508ec8054900a1abe1b99 100644
--- a/LayoutTests/fast/encoding/api/end-of-file.html
+++ b/LayoutTests/fast/encoding/api/end-of-file.html
@@ -1,36 +1,50 @@
<!DOCTYPE html>
-<script src="../../../resources/js-test.js"></script>
+<title>Encoding API: End-of-file</title>
+<script src="../../../resources/testharness.js"></script>
+<script src="../../../resources/testharnessreport.js"></script>
<script>
-description("Edge cases around non-fatal errors at EOF");
+test(function() {
+ [
+ {encoding: 'utf-8', sequence: [0xC0]},
+ {encoding: 'utf-16le', sequence: [0x00]},
+ {encoding: 'utf-16be', sequence: [0x00]}
+ ].forEach(function(testCase) {
-shouldThrow("new TextDecoder('utf-8', {fatal: true}).decode(new Uint8Array([0xff]))");
+ assert_throws({name: 'EncodingError'}, function() {
+ var decoder = new TextDecoder(testCase.encoding, {fatal: true});
+ decoder.decode(new Uint8Array(testCase.sequence));
+ }, 'Unterminated ' + testCase.encoding + ' sequence should throw if fatal flag is set');
-debug("");
-shouldBe("new TextDecoder('utf-8').decode(new Uint8Array([0xff]))", "'\uFFFD'");
+ assert_equals(
+ new TextDecoder(testCase.encoding).decode(new Uint8Array([testCase.sequence])),
+ '\uFFFD',
+ 'Unterminated UTF-8 sequence should emit replacement character if fatal flag is unset');
+ });
+}, 'Fatal flag, non-streaming cases');
-debug("");
-shouldThrow("new TextDecoder('utf-16le', {fatal: true}).decode(new Uint8Array([0x00]))");
+test(function() {
-debug("");
-shouldBe("new TextDecoder('utf-16le').decode(new Uint8Array([0x00]))", "'\uFFFD'");
+ var decoder = new TextDecoder('utf-16le', {fatal: true});
+ var odd = new Uint8Array([0x00]);
+ var even = new Uint8Array([0x00, 0x00]);
-debug("");
-shouldThrow("new TextDecoder('utf-16be', {fatal: true}).decode(new Uint8Array([0x00]))");
+ assert_equals(decoder.decode(odd, {stream: true}), '');
+ assert_equals(decoder.decode(odd), '\u0000');
-debug("");
-shouldBe("new TextDecoder('utf-16be').decode(new Uint8Array([0x00]))", "'\uFFFD'");
+ assert_throws({name: 'EncodingError'}, function() {
+ decoder.decode(even, {stream: true});
+ decoder.decode(odd)
+ });
-debug("");
-debug("Streaming cases:");
-evalAndLog("decoder = new TextDecoder('utf-16le', {fatal: true})");
-evalAndLog("odd = new Uint8Array([0x00])");
-evalAndLog("even = new Uint8Array([0x00, 0x00])");
+ assert_throws({name: 'EncodingError'}, function() {
+ decoder.decode(odd, {stream: true});
+ decoder.decode(even);
+ });
-debug("");
-shouldNotThrow("decoder.decode(odd, {stream: true}); decoder.decode(odd)");
-shouldThrow("decoder.decode(even, {stream: true}); decoder.decode(odd)");
-shouldThrow("decoder.decode(odd, {stream: true}); decoder.decode(even)");
-shouldNotThrow("decoder.decode(even, {stream: true}); decoder.decode(even)");
+ assert_equals(decoder.decode(even, {stream: true}), '\u0000');
+ assert_equals(decoder.decode(even), '\u0000');
+
+}, 'Fatal flag, streaming cases');
</script>
« no previous file with comments | « LayoutTests/fast/encoding/api/encoding-names-expected.txt ('k') | LayoutTests/fast/encoding/api/end-of-file-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698