Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2402823002: Remove some NeedsManualRebaseline entries (Closed)

Created:
4 years, 2 months ago by xidachen
Modified:
4 years, 2 months ago
Reviewers:
f(malita)
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some NeedsManualRebaseline entries In a previous CL: https://codereview.chromium.org/2396753003/ we label some entries in layout tests expectations to be NeedsManualRebaseline in order to land a skia change: https://codereview.chromium.org/2388833002/ Once the skia roll is in, we should remove these NeedsManualRebaseline and do a Rebaseline BUG=640031 TBR=fmalita@chromium.org Committed: https://crrev.com/ed82aa88e61c002a7acd172f6416bad70beb3d50 Cr-Commit-Position: refs/heads/master@{#424103}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2402823002/1
4 years, 2 months ago (2016-10-09 14:48:57 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-09 16:14:54 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-10-09 16:16:57 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed82aa88e61c002a7acd172f6416bad70beb3d50
Cr-Commit-Position: refs/heads/master@{#424103}

Powered by Google App Engine
This is Rietveld 408576698