Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2402793002: [Android] Add timeout to unmap reply handling. (Closed)

Created:
4 years, 2 months ago by jbudorick
Modified:
4 years, 2 months ago
Reviewers:
Ted C
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add timeout to unmap reply handling. BUG=652250 Committed: https://crrev.com/06a677a5adc5a85a4c6516f822a3930fe2427128 Cr-Commit-Position: refs/heads/master@{#424043}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -6 lines) Patch
M tools/android/forwarder2/command.h View 1 chunk +9 lines, -0 lines 0 comments Download
M tools/android/forwarder2/command.cc View 3 chunks +17 lines, -1 line 0 comments Download
M tools/android/forwarder2/host_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/android/forwarder2/socket.h View 2 chunks +6 lines, -0 lines 0 comments Download
M tools/android/forwarder2/socket.cc View 3 chunks +17 lines, -4 lines 2 comments Download

Messages

Total messages: 9 (3 generated)
jbudorick
this week's edition of Friday Forwarder Fun
4 years, 2 months ago (2016-10-08 00:07:31 UTC) #2
Ted C
lgtm https://codereview.chromium.org/2402793002/diff/1/tools/android/forwarder2/socket.cc File tools/android/forwarder2/socket.cc (right): https://codereview.chromium.org/2402793002/diff/1/tools/android/forwarder2/socket.cc#newcode435 tools/android/forwarder2/socket.cc:435: if (HANDLE_EINTR(select(max_fd + 1, &read_fds, &write_fds, NULL, tv_ptr)) ...
4 years, 2 months ago (2016-10-08 00:16:32 UTC) #3
jbudorick
https://codereview.chromium.org/2402793002/diff/1/tools/android/forwarder2/socket.cc File tools/android/forwarder2/socket.cc (right): https://codereview.chromium.org/2402793002/diff/1/tools/android/forwarder2/socket.cc#newcode435 tools/android/forwarder2/socket.cc:435: if (HANDLE_EINTR(select(max_fd + 1, &read_fds, &write_fds, NULL, tv_ptr)) < ...
4 years, 2 months ago (2016-10-08 00:30:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2402793002/1
4 years, 2 months ago (2016-10-08 00:51:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-08 02:06:00 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-08 02:07:37 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/06a677a5adc5a85a4c6516f822a3930fe2427128
Cr-Commit-Position: refs/heads/master@{#424043}

Powered by Google App Engine
This is Rietveld 408576698