Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2402763002: Revert of Log extra information on weird ToastManagerTest.PositionWithVisibleLeftShelf flake. (Closed)

Created:
4 years, 2 months ago by gab
Modified:
4 years, 2 months ago
Reviewers:
sadrul
CC:
chromium-reviews, kalyank, yoshiki, nasko
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Log extra information on weird ToastManagerTest.PositionWithVisibleLeftShelf flake. (patchset #1 id:20001 of https://codereview.chromium.org/2394483006/ ) Reason for revert: https://codereview.chromium.org/2391823004/ will fix http://crbug.com/650925 and can't land as-is (patch failure) because of this CL Original issue's description: > Log extra information on weird ToastManagerTest.PositionWithVisibleLeftShelf flake. > > BUG=650925 > TBR=sadrul > > Committed: https://crrev.com/d7cbf7ccc5f21177c925657fd50c688ca437526a > Cr-Commit-Position: refs/heads/master@{#423635} TBR=sadrul@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=650925 Committed: https://crrev.com/b407c4aba81c739c364901214ee203acda162281 Cr-Commit-Position: refs/heads/master@{#423928}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M ash/system/toast/toast_manager_unittest.cc View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
gab
Created Revert of Log extra information on weird ToastManagerTest.PositionWithVisibleLeftShelf flake.
4 years, 2 months ago (2016-10-07 19:14:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2402763002/1
4 years, 2 months ago (2016-10-07 19:14:47 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 19:23:23 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 19:24:56 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b407c4aba81c739c364901214ee203acda162281
Cr-Commit-Position: refs/heads/master@{#423928}

Powered by Google App Engine
This is Rietveld 408576698