Issue 240273005: Simplify the HTMLCollection destructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 240273005: Simplify the HTMLCollection destructor (Closed)

Created:
6 years, 8 months ago by Inactive

Modified:
6 years, 8 months ago

Reviewers:
esprehn, adamk

CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Simplify the HTMLCollection destructor Simplify the HTMLCollection destructor by restructuring the CollectionType enumeration a bit and adding a isUnnamedHTMLCollectionType() convenience function. We now use the isUnnamedHTMLCollectionType() in the HTMLCollection destructor instead of enumerating all the "exception" types. R=esprehn@chromium.org,adamk@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171884

Patch Set 1 #

Patch Set 2 : Fix comments #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -8 lines)			Patch
	M	Source/core/html/CollectionType.h	View	1	3 chunks	+11 lines, -4 lines	1 comment	Download
	M	Source/core/html/HTMLCollection.cpp	View		1 chunk	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

adamk

lgtm https://codereview.chromium.org/240273005/diff/20001/Source/core/html/CollectionType.h File Source/core/html/CollectionType.h (right): https://codereview.chromium.org/240273005/diff/20001/Source/core/html/CollectionType.h#newcode68 Source/core/html/CollectionType.h:68: static const CollectionType FirstLiveNodeListType = NameNodeListType; Not sure ...

6 years, 8 months ago (2014-04-17 18:08:08 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/240273005/20001

6 years, 8 months ago (2014-04-17 19:54:05 UTC) #4

Message was sent while issue was closed.

Change committed as 171884

Expand Messages | Collapse Messages