always store bitfields along with dirty in FlatteningTraits

always store bitfields along with dirty in FlatteningTraits

This allows us to simplify lots of setters in SkPaint, which in the non-android case, could now be just assignments (and therefore inlineable).

Committed: http://code.google.com/p/skia/source/detail?r=14229

[robertphillips, 2014-04-16 15:39:33]

lgtm

https://codereview.chromium.org/240273004/diff/1/src/core/SkPaint.cpp
File src/core/SkPaint.cpp (right):

https://codereview.chromium.org/240273004/diff/1/src/core/SkPaint.cpp#newcode39
src/core/SkPaint.cpp:39: kColor_DirtyBit               = 1 <<  0,
Just delete?

https://codereview.chromium.org/240273004/diff/1/src/core/SkPaint.cpp#newcode...
src/core/SkPaint.cpp:2663: *u32++ = dirty;
This is minor but, would it make more sense to read/write the bitfields before
the dirty word?

[tomhudson, 2014-04-16 15:45:10]

lgtm

[mtklein, 2014-04-16 15:53:23]

code lgtm.  some suggestions on the comments

https://codereview.chromium.org/240273004/diff/1/src/core/SkPaint.cpp
File src/core/SkPaint.cpp (right):

https://codereview.chromium.org/240273004/diff/1/src/core/SkPaint.cpp#newcode39
src/core/SkPaint.cpp:39: kColor_DirtyBit               = 1 <<  0,
On 2014/04/16 15:39:33, robertphillips wrote:
> Just delete?

Or // Bit 1 is safe to reuse.

https://codereview.chromium.org/240273004/diff/1/src/core/SkPaint.cpp#newcode...
src/core/SkPaint.cpp:2658: // Each of the low 7 dirty bits corresponds to a
4-byte flat value,
// Each of bits 0,2,3,4,5, and 6 corresponds to a 4-byte flat value,

[mtklein, 2014-04-16 15:54:43]

Wait!  not lgtm.

https://codereview.chromium.org/240273004/diff/1/src/core/SkPaint.cpp
File src/core/SkPaint.cpp (right):

https://codereview.chromium.org/240273004/diff/1/src/core/SkPaint.cpp#newcode39
src/core/SkPaint.cpp:39: kColor_DirtyBit               = 1 <<  0,
On 2014/04/16 15:53:23, mtklein wrote:
> On 2014/04/16 15:39:33, robertphillips wrote:
> > Just delete?
> 
> Or // Bit 1 is safe to reuse.

Actually.  Hold on.  Let's just shift everyone down.
So we can write // Each of bottom 6 bits ... and mask with 63 instead of 127,
etc.

We can change this enum freely without breaking picture version.

[reed1, 2014-04-16 20:22:05]

On 2014/04/16 15:54:43, mtklein wrote:
> Wait!  not lgtm.
> 
> https://codereview.chromium.org/240273004/diff/1/src/core/SkPaint.cpp
> File src/core/SkPaint.cpp (right):
> 
>
https://codereview.chromium.org/240273004/diff/1/src/core/SkPaint.cpp#newcode39
> src/core/SkPaint.cpp:39: kColor_DirtyBit               = 1 <<  0,
> On 2014/04/16 15:53:23, mtklein wrote:
> > On 2014/04/16 15:39:33, robertphillips wrote:
> > > Just delete?
> > 
> > Or // Bit 1 is safe to reuse.
> 
> Actually.  Hold on.  Let's just shift everyone down.
> So we can write // Each of bottom 6 bits ... and mask with 63 instead of 127,
> etc.
> 
> We can change this enum freely without breaking picture version.

And I get to update the unitest as well :)

[reed1, 2014-04-16 20:27:34]

PTAL

[mtklein, 2014-04-16 20:28:25]

lgtm

[reed1, 2014-04-16 20:28:38]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-04-16 20:28:56]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/reed@google.com/240273004/20003

[commit-bot: I haz the power, 2014-04-16 20:48:12]

Change committed as 14229