Close the ntp during startup when opening a link on Mac.

chrome/browser/app_controller_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/app_controller_mac.h"
 
 #include "apps/app_shim/app_shim_mac.h"
 #include "apps/app_shim/extension_app_shim_handler_mac.h"
 #include "apps/app_window_registry.h"
 #include "base/auto_reset.h"
@@ skipping 711 matching lines @@
 
   // Makes "Services" menu items available.
   [self registerServicesMenuTypesTo:[notify object]];
 
   startupComplete_ = YES;
 
   // TODO(viettrungluu): This is very temporary, since this should be done "in"
   // |BrowserMain()|, i.e., this list of startup URLs should be appended to the
   // (probably-empty) list of URLs from the command line.
   if (startupUrls_.size()) {
+    // The browser is already loaded at this point with the new tab page.

[Alexei Svitkine (slow), 2014/04/16 14:35:30]

Could you make a new method wrapping all of this logic? e.g. -openStartupUrls

+    int ntp_index;

[Alexei Svitkine (slow), 2014/04/16 14:35:30]

Nit: Init this to a dummy value.

+    Browser* browser = chrome::GetLastActiveBrowser();
+    if (browser) {
+      DCHECK(browser->tab_strip_model()->count() == 1);

[Alexei Svitkine (slow), 2014/04/16 14:35:30]

DCHECK_EQ?

Also, are you sure this will always be true? For example, I think on first
launch I remember there could be two tabs open.

Is there a way to make this logic more robust (e.g. checking if a tab is
actually the NTP?). Or perhaps it should remove all tabs other than the new ones
opened?

+      ntp_index = browser->tab_strip_model()->active_index();
+    }
+
     [self openUrls:startupUrls_];
     [self clearStartupUrls];
+
+    // Close the new tab page after opening urls to prevent from closing the

[Alexei Svitkine (slow), 2014/04/16 14:35:30]

Nit: Remove "from".

+    // browser window.
+    if (browser)

[Alexei Svitkine (slow), 2014/04/16 14:35:30]

Nit: add {}'s

+      browser->tab_strip_model()->CloseWebContentsAt(ntp_index,
+          TabStripModel::CLOSE_NONE);
   }
 
   PrefService* localState = g_browser_process->local_state();
   if (localState) {
     localPrefRegistrar_.Init(localState);
     localPrefRegistrar_.Add(
         prefs::kAllowFileSelectionDialogs,
         base::Bind(&chrome::BrowserCommandController::UpdateOpenFileState,
                    menuState_.get()));
   }
@@ skipping 751 matching lines @@
 
 //---------------------------------------------------------------------------
 
 namespace app_controller_mac {
 
 bool IsOpeningNewWindow() {
   return g_is_opening_new_window;
 }
 
 }  // namespace app_controller_mac