Replace BazelWorkspace factory with the static 'find' method.

pkg/analyzer/test/generated/bazel_test.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.test.generated.bazel_test;
 
 import 'package:analyzer/file_system/memory_file_system.dart';
 import 'package:analyzer/src/generated/bazel.dart';
 import 'package:analyzer/src/generated/source.dart';
 import 'package:test/test.dart';
 import 'package:test_reflective_loader/test_reflective_loader.dart';
 
 main() {
   defineReflectiveSuite(() {
     defineReflectiveTests(BazelFileUriResolverTest);
     defineReflectiveTests(BazelPackageUriResolverTest);
     defineReflectiveTests(BazelWorkspaceTest);
   });
 }
 
 @reflectiveTest
 class BazelFileUriResolverTest extends _BaseTest {
   BazelWorkspace workspace;
   BazelFileUriResolver resolver;
 
   void setUp() {
     provider.newFile(_p('/workspace/WORKSPACE'), '');
-    workspace = new BazelWorkspace(provider, _p('/workspace'));
+    workspace = BazelWorkspace.find(provider, _p('/workspace'));
     resolver = new BazelFileUriResolver(workspace);
     provider.newFile(_p('/workspace/test.dart'), '');
     provider.newFile(_p('/workspace/bazel-bin/gen1.dart'), '');
     provider.newFile(_p('/workspace/bazel-genfiles/gen2.dart'), '');
   }
 
   void test_resolveAbsolute_doesNotExist() {
     Source source = _resolvePath('/workspace/foo.dart');
     expect(source, isNotNull);
     expect(source.exists(), isFalse);
@@ skipping 58 matching lines @@
   }
 }
 
 @reflectiveTest
 class BazelPackageUriResolverTest extends _BaseTest {
   BazelWorkspace workspace;
   BazelPackageUriResolver resolver;
 
   void setUp() {
     provider.newFile(_p('/workspace/WORKSPACE'), '');
-    workspace = new BazelWorkspace(provider, _p('/workspace'));
+    workspace = BazelWorkspace.find(provider, _p('/workspace'));
     resolver = new BazelPackageUriResolver(workspace);
     provider.newFile(_p('/workspace/my/foo/lib/foo1.dart'), '');
     provider.newFile(_p('/workspace/my/foo/lib/gen1.dart'), '');
     provider.newFile(_p('/workspace/my/foo/lib/gen2.dart'), '');
     provider.newFile(_p('/workspace/my/foo/lib/src/foo4.dart'), '');
     provider.newFile(_p('/workspace/third_party/dart/bar/lib/bar1.dart'), '');
     provider.newFile(
         _p('/workspace/third_party/dart/bar/lib/src/bar2.dart'), '');
     provider.newFile(_p('/workspace/bazel-bin/my/foo/lib/gen1.dart'), '');
     provider.newFile(_p('/workspace/bazel-genfiles/my/foo/lib/gen2.dart'), '');
@@ skipping 66 matching lines @@
     Source source = resolver.resolveAbsolute(uri);
     expect(source, isNotNull);
     expect(source.fullName, _p(posixPath));
     expect(source.uri, uri);
     expect(source.exists(), exists);
   }
 }
 
 @reflectiveTest
 class BazelWorkspaceTest extends _BaseTest {
-  void test_factory_fail_notAbsolute() {
-    expect(() => new BazelWorkspace(provider, _p('not_absolute')),
+  void test_find_fail_notAbsolute() {
+    expect(() => BazelWorkspace.find(provider, _p('not_absolute')),
         throwsArgumentError);
   }
 
-  void test_factory_hasReadonlyFolder() {
+  void test_find_hasReadonlyFolder() {
     provider.newFolder(_p('/Users/user/test/READONLY/prime'));
     provider.newFolder(_p('/Users/user/test/prime'));
-    BazelWorkspace workspace = new BazelWorkspace(
+    BazelWorkspace workspace = BazelWorkspace.find(
         provider, _p('/Users/user/test/prime/my/module'),
         readonlySuffix: 'prime');
     expect(workspace.root, _p('/Users/user/test/prime'));
     expect(workspace.readonly, _p('/Users/user/test/READONLY/prime'));
     expect(workspace.bin, _p('/Users/user/test/prime/bazel-bin'));
     expect(workspace.genfiles, _p('/Users/user/test/prime/bazel-genfiles'));
   }
 
-  void test_factory_hasWorkspaceFile() {
+  void test_find_hasWorkspaceFile() {
     provider.newFile(_p('/workspace/WORKSPACE'), '');
     BazelWorkspace workspace =
-        new BazelWorkspace(provider, _p('/workspace/my/module'));
+        BazelWorkspace.find(provider, _p('/workspace/my/module'));
     expect(workspace.root, _p('/workspace'));
     expect(workspace.readonly, isNull);
     expect(workspace.bin, _p('/workspace/bazel-bin'));
     expect(workspace.genfiles, _p('/workspace/bazel-genfiles'));
   }
 
-  void test_factory_hasWorkspaceFile_forModuleInWorkspace() {
+  void test_find_hasWorkspaceFile_forModuleInWorkspace() {
     provider.newFile(_p('/workspace/WORKSPACE'), '');
     BazelWorkspace workspace =
-        new BazelWorkspace(provider, _p('/workspace/my/module'));
+        BazelWorkspace.find(provider, _p('/workspace/my/module'));
     expect(workspace.root, _p('/workspace'));
     expect(workspace.readonly, isNull);
     expect(workspace.bin, _p('/workspace/bazel-bin'));
     expect(workspace.genfiles, _p('/workspace/bazel-genfiles'));
   }
 
-  void test_factory_hasWorkspaceFile_forWorkspace() {
+  void test_find_hasWorkspaceFile_forWorkspace() {
     provider.newFile(_p('/workspace/WORKSPACE'), '');
-    BazelWorkspace workspace = new BazelWorkspace(provider, _p('/workspace'));
+    provider.newFolder(_p('/workspace/bazel-bin'));
+    BazelWorkspace workspace = BazelWorkspace.find(provider, _p('/workspace'));
     expect(workspace.root, _p('/workspace'));
     expect(workspace.readonly, isNull);
     expect(workspace.bin, _p('/workspace/bazel-bin'));
     expect(workspace.genfiles, _p('/workspace/bazel-genfiles'));
   }
 
-  void test_factory_notInWorkspace() {
+  void test_find_null_noWorkspaceMarkers() {
     BazelWorkspace workspace =
-        new BazelWorkspace(provider, _p('/workspace/my/module'));
-    expect(workspace, isNotNull);
-    expect(workspace.root, _p('/workspace/my/module'));
-    expect(workspace.readonly, isNull);
-    expect(workspace.bin, isNull);
-    expect(workspace.genfiles, isNull);
+        BazelWorkspace.find(provider, _p('/workspace/my/module'));
+    expect(workspace, isNull);
   }
 
-  void test_factory_symlinkPrefix() {
+  void test_find_null_noWorkspaceMarkers_inRoot() {
+    BazelWorkspace workspace = BazelWorkspace.find(provider, _p('/'));
+    expect(workspace, isNull);
+  }
+
+  void test_find_null_noWorkspaceMarkers_inRoot_withReadonly() {
+    BazelWorkspace workspace =
+        BazelWorkspace.find(provider, _p('/'), readonlySuffix: 'READONLY');
+    expect(workspace, isNull);
+  }
+
+  void test_find_symlinkPrefix() {
     provider.newFile(_p('/workspace/WORKSPACE'), '');
-    BazelWorkspace workspace =
-        new BazelWorkspace(provider, _p('/workspace'), symlinkPrefix: 'foobar');
+    BazelWorkspace workspace = BazelWorkspace.find(provider, _p('/workspace'),
+        symlinkPrefix: 'foobar');
     expect(workspace.root, _p('/workspace'));
     expect(workspace.readonly, isNull);
     expect(workspace.bin, _p('/workspace/foobar-bin'));
     expect(workspace.genfiles, _p('/workspace/foobar-genfiles'));
   }
 
   void test_findFile_hasReadonlyFolder() {
     provider.newFolder(_p('/Users/user/test/READONLY/prime'));
     provider.newFolder(_p('/Users/user/test/prime'));
     provider.newFile(_p('/Users/user/test/prime/my/module/test1.dart'), '');
     provider.newFile(_p('/Users/user/test/prime/my/module/test2.dart'), '');
     provider.newFile(_p('/Users/user/test/prime/my/module/test3.dart'), '');
     provider.newFile(
         _p('/Users/user/test/prime/bazel-bin/my/module/test2.dart'), '');
     provider.newFile(
         _p('/Users/user/test/prime/bazel-genfiles/my/module/test3.dart'), '');
     provider.newFile(
         _p('/Users/user/test/READONLY/prime/other/module/test4.dart'), '');
-    BazelWorkspace workspace = new BazelWorkspace(
+    BazelWorkspace workspace = BazelWorkspace.find(
         provider, _p('/Users/user/test/prime/my/module'),
         readonlySuffix: 'prime');
     expect(
         workspace
             .findFile(_p('/Users/user/test/prime/my/module/test1.dart'))
             .path,
         _p('/Users/user/test/prime/my/module/test1.dart'));
     expect(
         workspace
             .findFile(_p('/Users/user/test/prime/my/module/test2.dart'))
@@ skipping 12 matching lines @@
   }
 
   void test_findFile_noReadOnly() {
     provider.newFile(_p('/workspace/WORKSPACE'), '');
     provider.newFile(_p('/workspace/my/module/test1.dart'), '');
     provider.newFile(_p('/workspace/my/module/test2.dart'), '');
     provider.newFile(_p('/workspace/my/module/test3.dart'), '');
     provider.newFile(_p('/workspace/bazel-bin/my/module/test2.dart'), '');
     provider.newFile(_p('/workspace/bazel-genfiles/my/module/test3.dart'), '');
     BazelWorkspace workspace =
-        new BazelWorkspace(provider, _p('/workspace/my/module'));
+        BazelWorkspace.find(provider, _p('/workspace/my/module'));
     expect(workspace.findFile(_p('/workspace/my/module/test1.dart')).path,
         _p('/workspace/my/module/test1.dart'));
     expect(workspace.findFile(_p('/workspace/my/module/test2.dart')).path,
         _p('/workspace/bazel-bin/my/module/test2.dart'));
     expect(workspace.findFile(_p('/workspace/my/module/test3.dart')).path,
         _p('/workspace/bazel-genfiles/my/module/test3.dart'));
   }
 }
 
 class _BaseTest {
   final MemoryResourceProvider provider = new MemoryResourceProvider();
 
   /**
    * Return the [provider] specific path for the given Posix [path].
    */
   String _p(String path) => provider.convertPath(path);
 }