Replace BazelWorkspace factory with the static 'find' method.

Replace BazelWorkspace factory with the static 'find' method.

This is a breaking change:

1. The factory constructor was removed.
2. The method find() may return null.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/84b1a981734d4cb3b44df00e5f07e24aa8d1bde2

[Paul Berry, 2016-10-07 17:08:37]

lgtm with minor nits.  Thanks!

https://codereview.chromium.org/2402713002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/bazel.dart (right):

https://codereview.chromium.org/2402713002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/bazel.dart:179: */
Can you add a line to the doc comment explaining when find() is expected to
return null?

https://codereview.chromium.org/2402713002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/bazel.dart:198: if (readonlySuffix != null &&
parent != null) {
You can drop `&& parent != null` from this line because of the null check above.

[Brian Wilkerson, 2016-10-07 17:09:34]

lgtm, thanks!

[scheglov, 2016-10-07 17:15:38]

Description was changed from

==========
Replace BazelWorkspace factory with the static 'find' method.

This is a breaking change:

1. The factory constructor was removed.
2. The method find() may return null.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Replace BazelWorkspace factory with the static 'find' method.

This is a breaking change:

1. The factory constructor was removed.
2. The method find() may return null.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/84b1a981734d4cb3b44df00e5f07e24aa8d1bde2
==========

[scheglov, 2016-10-07 17:15:39]

Committed patchset #2 (id:20001) manually as
84b1a981734d4cb3b44df00e5f07e24aa8d1bde2 (presubmit successful).

[scheglov, 2016-10-07 17:15:56]

https://codereview.chromium.org/2402713002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/bazel.dart (right):

https://codereview.chromium.org/2402713002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/bazel.dart:179: */
On 2016/10/07 17:08:36, Paul Berry wrote:
> Can you add a line to the doc comment explaining when find() is expected to
> return null?

Done.

https://codereview.chromium.org/2402713002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/bazel.dart:198: if (readonlySuffix != null &&
parent != null) {
On 2016/10/07 17:08:36, Paul Berry wrote:
> You can drop `&& parent != null` from this line because of the null check
above.

Done.