Issue 24027004: thread isolate for HConstant::handle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24027004: thread isolate for HConstant::handle (Closed)

Created:
7 years, 3 months ago by dcarney

Modified:
7 years, 3 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -32 lines)			Patch
M	src/arm/lithium-arm.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	6 chunks	+6 lines, -6 lines	0 comments	Download
M	src/hydrogen.cc	View	3 chunks	+9 lines, -5 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	5 chunks	+6 lines, -6 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/ia32/lithium-ia32.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/x64/lithium-x64.h	View	1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Sven Panne

LGTM. Only a few Isolate::Current() calls were introduced... ;-)

7 years, 3 months ago (2013-09-06 12:45:53 UTC) #2

dcarney

7 years, 3 months ago (2013-09-09 07:57:37 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r16587 (presubmit successful).