Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: tools/perf/benchmarks/smoothness.py

Issue 2402693002: Disable smoothnes.top_25_smooth on Win reference (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/smoothness.py
diff --git a/tools/perf/benchmarks/smoothness.py b/tools/perf/benchmarks/smoothness.py
index 168e862c2123fea125e0bdc077cde4d73fe3b28a..56facc96ec1012f0cb6ff8112c5db856ad9897cb 100644
--- a/tools/perf/benchmarks/smoothness.py
+++ b/tools/perf/benchmarks/smoothness.py
@@ -49,9 +49,16 @@ class SmoothnessTop25(_Smoothness):
return 'smoothness.top_25_smooth'
@classmethod
- def ShouldDisable(cls, possible_browser): # http://crbug.com/597656
- return (possible_browser.browser_type == 'reference' and
- possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X')
+ def ShouldDisable(cls, possible_browser):
+ # http://crbug.com/597656
+ if (possible_browser.browser_type == 'reference' and
+ possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X'):
+ return True
+ # http://crbug.com/650762
+ if (possible_browser.browser_type == 'reference' and
+ possible_browser.platform.GetOSName() == 'win'):
+ return True
+ return False
class SmoothnessToughFiltersCases(_Smoothness):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698