Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2402673002: Implemented Missing Virtual Functions Declaration in DirectRenderer Class.

Created:
4 years, 2 months ago by Soorya
Modified:
4 years, 2 months ago
Reviewers:
a.suchit2, danakj, a.suchit
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implemented Missing Virtual Functions Declaration in DirectRenderer Class. EnsureBackbuffer , DiscardBackbuffer and ReceiveSwapBuffersAck Functions were marked overridden in VulkanRenderer class but were not declared in DirectRenderer class. Added the declaration of above mentioned functions in DirectRenderer class. BUG = 582558 , 582564

Patch Set 1 #

Patch Set 2 : Removed unwanted changes/files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M cc/output/direct_renderer.h View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
Soorya
Please Review
4 years, 2 months ago (2016-10-08 08:40:21 UTC) #6
a.suchit2
Please upload a single patch for all the build issues in vulkan. peer review not ...
4 years, 2 months ago (2016-10-10 10:52:47 UTC) #7
danakj
4 years, 2 months ago (2016-10-10 20:10:56 UTC) #9
If they're not part of direct renderer then they aren't called from direct
renderer. They should be removed from vulkan renderer or callsites would need to
be added if they are needed.

Powered by Google App Engine
This is Rietveld 408576698