Reland "[turbofan] Discard the shared code entry in the optimized code map."

test/cctest/test-compiler.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 388 matching lines @@
         v8::Utils::OpenHandle(*v8::Local<v8::Function>::Cast(
             env->Global()
                 ->Get(env.local(), v8_str("closure2"))
                 .ToLocalChecked())));
     CHECK(fun1->IsOptimized() || !CcTest::i_isolate()->use_crankshaft());
     CHECK(fun2->IsOptimized() || !CcTest::i_isolate()->use_crankshaft());
     CHECK_EQ(fun1->code(), fun2->code());
   }
 }
 
-// Test that optimized code for different closures is actually shared.
-TEST(OptimizedCodeSharing2) {
-  if (FLAG_stress_compaction) return;
-  FLAG_allow_natives_syntax = true;
-  FLAG_native_context_specialization = false;
-  FLAG_turbo_cache_shared_code = true;
-  const char* flag = "--turbo-filter=*";
-  FlagList::SetFlagsFromString(flag, StrLength(flag));
-  CcTest::InitializeVM();
-  v8::HandleScope scope(CcTest::isolate());
-  v8::Local<v8::Script> script = v8_compile(
-      "function MakeClosure() {"
-      "  return function() { return x; };"
-      "}");
-  Handle<Code> reference_code;
-  {
-    LocalContext env;
-    env->Global()
-        ->Set(env.local(), v8_str("x"), v8::Integer::New(CcTest::isolate(), 23))
-        .FromJust();
-    script->GetUnboundScript()
-        ->BindToCurrentContext()
-        ->Run(env.local())
-        .ToLocalChecked();
-    CompileRun(
-        "var closure0 = MakeClosure();"
-        "%DebugPrint(closure0());"
-        "%OptimizeFunctionOnNextCall(closure0);"
-        "%DebugPrint(closure0());");
-    Handle<JSFunction> fun0 = Handle<JSFunction>::cast(
-        v8::Utils::OpenHandle(*v8::Local<v8::Function>::Cast(
-            env->Global()
-                ->Get(env.local(), v8_str("closure0"))
-                .ToLocalChecked())));
-    CHECK(fun0->IsOptimized() || !CcTest::i_isolate()->use_crankshaft());
-    reference_code = handle(fun0->code());
-  }
-  for (int i = 0; i < 3; i++) {
-    LocalContext env;
-    env->Global()
-        ->Set(env.local(), v8_str("x"), v8::Integer::New(CcTest::isolate(), i))
-        .FromJust();
-    script->GetUnboundScript()
-        ->BindToCurrentContext()
-        ->Run(env.local())
-        .ToLocalChecked();
-    CompileRun(
-        "var closure0 = MakeClosure();"
-        "%DebugPrint(closure0());"
-        "%OptimizeFunctionOnNextCall(closure0);"
-        "%DebugPrint(closure0());"
-        "var closure1 = MakeClosure(); closure1();"
-        "var closure2 = MakeClosure(); closure2();");
-    Handle<JSFunction> fun1 = Handle<JSFunction>::cast(
-        v8::Utils::OpenHandle(*v8::Local<v8::Function>::Cast(
-            env->Global()
-                ->Get(env.local(), v8_str("closure1"))
-                .ToLocalChecked())));
-    Handle<JSFunction> fun2 = Handle<JSFunction>::cast(
-        v8::Utils::OpenHandle(*v8::Local<v8::Function>::Cast(
-            env->Global()
-                ->Get(env.local(), v8_str("closure2"))
-                .ToLocalChecked())));
-    CHECK(fun1->IsOptimized() || !CcTest::i_isolate()->use_crankshaft());
-    CHECK(fun2->IsOptimized() || !CcTest::i_isolate()->use_crankshaft());
-    CHECK_EQ(*reference_code, fun1->code());
-    CHECK_EQ(*reference_code, fun2->code());
-  }
-}
-
-// Test that optimized code for different closures is actually shared.
-TEST(OptimizedCodeSharing3) {
-  if (FLAG_stress_compaction) return;
-  FLAG_allow_natives_syntax = true;
-  FLAG_native_context_specialization = false;
-  FLAG_turbo_cache_shared_code = true;
-  const char* flag = "--turbo-filter=*";
-  FlagList::SetFlagsFromString(flag, StrLength(flag));
-  CcTest::InitializeVM();
-  v8::HandleScope scope(CcTest::isolate());
-  v8::Local<v8::Script> script = v8_compile(
-      "function MakeClosure() {"
-      "  return function() { return x; };"
-      "}");
-  Handle<Code> reference_code;
-  {
-    LocalContext env;
-    env->Global()
-        ->Set(env.local(), v8_str("x"), v8::Integer::New(CcTest::isolate(), 23))
-        .FromJust();
-    script->GetUnboundScript()
-        ->BindToCurrentContext()
-        ->Run(env.local())
-        .ToLocalChecked();
-    CompileRun(
-        "var closure0 = MakeClosure();"
-        "%DebugPrint(closure0());"
-        "%OptimizeFunctionOnNextCall(closure0);"
-        "%DebugPrint(closure0());");
-    Handle<JSFunction> fun0 = Handle<JSFunction>::cast(
-        v8::Utils::OpenHandle(*v8::Local<v8::Function>::Cast(
-            env->Global()
-                ->Get(env.local(), v8_str("closure0"))
-                .ToLocalChecked())));
-    CHECK(fun0->IsOptimized() || !CcTest::i_isolate()->use_crankshaft());
-    reference_code = handle(fun0->code());
-    // Evict only the context-dependent entry from the optimized code map. This
-    // leaves it in a state where only the context-independent entry exists.
-    fun0->shared()->TrimOptimizedCodeMap(SharedFunctionInfo::kEntryLength);
-  }
-  for (int i = 0; i < 3; i++) {
-    LocalContext env;
-    env->Global()
-        ->Set(env.local(), v8_str("x"), v8::Integer::New(CcTest::isolate(), i))
-        .FromJust();
-    script->GetUnboundScript()
-        ->BindToCurrentContext()
-        ->Run(env.local())
-        .ToLocalChecked();
-    CompileRun(
-        "var closure0 = MakeClosure();"
-        "%DebugPrint(closure0());"
-        "%OptimizeFunctionOnNextCall(closure0);"
-        "%DebugPrint(closure0());"
-        "var closure1 = MakeClosure(); closure1();"
-        "var closure2 = MakeClosure(); closure2();");
-    Handle<JSFunction> fun1 = Handle<JSFunction>::cast(
-        v8::Utils::OpenHandle(*v8::Local<v8::Function>::Cast(
-            env->Global()
-                ->Get(env.local(), v8_str("closure1"))
-                .ToLocalChecked())));
-    Handle<JSFunction> fun2 = Handle<JSFunction>::cast(
-        v8::Utils::OpenHandle(*v8::Local<v8::Function>::Cast(
-            env->Global()
-                ->Get(env.local(), v8_str("closure2"))
-                .ToLocalChecked())));
-    CHECK(fun1->IsOptimized() || !CcTest::i_isolate()->use_crankshaft());
-    CHECK(fun2->IsOptimized() || !CcTest::i_isolate()->use_crankshaft());
-    CHECK_EQ(*reference_code, fun1->code());
-    CHECK_EQ(*reference_code, fun2->code());
-  }
-}
-
-
 TEST(CompileFunctionInContext) {
   CcTest::InitializeVM();
   v8::HandleScope scope(CcTest::isolate());
   LocalContext env;
   CompileRun("var r = 10;");
   v8::Local<v8::Object> math = v8::Local<v8::Object>::Cast(
       env->Global()->Get(env.local(), v8_str("Math")).ToLocalChecked());
   v8::ScriptCompiler::Source script_source(v8_str(
       "a = PI * r * r;"
       "x = r * cos(PI);"
@@ skipping 295 matching lines @@
   CompileRun("foo()");
   CHECK_EQ(2, foo->feedback_vector()->invocation_count());
   CompileRun("bar()");
   CHECK_EQ(2, foo->feedback_vector()->invocation_count());
   CompileRun("foo(); foo()");
   CHECK_EQ(4, foo->feedback_vector()->invocation_count());
   CompileRun("%BaselineFunctionOnNextCall(foo);");
   CompileRun("foo();");
   CHECK_EQ(5, foo->feedback_vector()->invocation_count());
 }