Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 2402663002: Reland "[turbofan] Discard the shared code entry in the optimized code map." (Closed)

Created:
4 years, 2 months ago by mvstanton
Modified:
4 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, v8-mips-ports_googlegroups.com, Michael Hablich, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "[turbofan] Discard the shared code entry in the optimized code map." (GcStress failure was unrelated.) At one time, we hoped to generate the same code for different native contexts. But in truth, much performance comes from optimizing on the native context. Now we abandon this pathway. BUG= TBR=bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true Committed: https://chromium.googlesource.com/v8/v8/+/ec132e05ec197e77b9ada8040eb5957cf4a753f5

Patch Set 1 #

Patch Set 2 : Patch failure(?) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -349 lines) Patch
M src/builtins/arm/builtins-arm.cc View 3 chunks +2 lines, -18 lines 0 comments Download
M src/builtins/arm64/builtins-arm64.cc View 3 chunks +1 line, -17 lines 0 comments Download
M src/builtins/ia32/builtins-ia32.cc View 3 chunks +2 lines, -18 lines 0 comments Download
M src/builtins/mips/builtins-mips.cc View 3 chunks +2 lines, -18 lines 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 3 chunks +2 lines, -18 lines 0 comments Download
M src/builtins/x64/builtins-x64.cc View 3 chunks +1 line, -17 lines 0 comments Download
M src/compiler.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/heap.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/heap.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/objects.h View 3 chunks +3 lines, -8 lines 0 comments Download
M src/objects.cc View 8 chunks +13 lines, -61 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +0 lines, -144 lines 0 comments Download

Messages

Total messages: 15 (12 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2402663002/20001
4 years, 2 months ago (2016-10-07 12:56:01 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ec132e05ec197e77b9ada8040eb5957cf4a753f5 Cr-Commit-Position: refs/heads/master@{#40086}
4 years, 2 months ago (2016-10-07 13:01:03 UTC) #13
mvstanton
4 years, 2 months ago (2016-10-07 13:01:09 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ec132e05ec197e77b9ada8040eb5957cf4a753f5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698