Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 2402653002: Document LayoutObject generation for whitespace nodes. (Closed)

Created:
4 years, 2 months ago by rune
Modified:
4 years, 2 months ago
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Document LayoutObject generation for whitespace nodes. R=eae@chromium.org,esprehn@chromium.org,mstensho@opera.com Committed: https://crrev.com/f32227fdce1e1179f8ca327aff633d50d9a41c67 Cr-Commit-Position: refs/heads/master@{#423947}

Patch Set 1 #

Patch Set 2 : Proof-reading #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -0 lines) Patch
A third_party/WebKit/Source/core/dom/WhitespaceLayoutObjects.md View 1 1 chunk +164 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rune
I've tried to document what I've learned from studying whitespace (re-)attachment. Does this make sense ...
4 years, 2 months ago (2016-10-07 11:44:17 UTC) #1
eae
This is great, thank you! LGTM
4 years, 2 months ago (2016-10-07 16:45:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2402653002/20001
4 years, 2 months ago (2016-10-07 17:57:24 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-07 20:03:54 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 20:07:05 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f32227fdce1e1179f8ca327aff633d50d9a41c67
Cr-Commit-Position: refs/heads/master@{#423947}

Powered by Google App Engine
This is Rietveld 408576698