Moves most of WorkspaceLayoutManagerTest into ash/common

Moves most of WorkspaceLayoutManagerTest into ash/common

Parts using the keyboard, which isn't refactored yet, remain in
ash/wm.

BUG=624172
TEST=test only changes
R=msw@chromium.org

Committed: https://crrev.com/9e4e404e6d5a7d5df2026dba3f17bcb6b2a6c00b
Cr-Commit-Position: refs/heads/master@{#424171}

[msw, 2016-10-07 23:06:12]

https://codereview.chromium.org/2402643004/diff/60001/ash/mus/BUILD.gn
File ash/mus/BUILD.gn (left):

https://codereview.chromium.org/2402643004/diff/60001/ash/mus/BUILD.gn#oldcod...
ash/mus/BUILD.gn:255: "workspace/workspace_layout_manager_unittest.cc",
Did you mean to git rm ash/mus/workspace/workspace_layout_manager_unittest.cc?
(Also, I haven't looked closely to compare that file with the others)

https://codereview.chromium.org/2402643004/diff/60001/ash/wm/workspace/worksp...
File ash/wm/workspace/workspace_layout_manager_keyboard_unittest.cc (right):

https://codereview.chromium.org/2402643004/diff/60001/ash/wm/workspace/worksp...
ash/wm/workspace/workspace_layout_manager_keyboard_unittest.cc:51: class
WorkspaceLayoutManagerKeyboardTest : public AshTest {
nit: add a TODO/comment about the temporary duplication and plans to consolidate
with the copypasta class in ash/common.

[sky, 2016-10-07 23:29:39]

https://codereview.chromium.org/2402643004/diff/60001/ash/mus/BUILD.gn
File ash/mus/BUILD.gn (left):

https://codereview.chromium.org/2402643004/diff/60001/ash/mus/BUILD.gn#oldcod...
ash/mus/BUILD.gn:255: "workspace/workspace_layout_manager_unittest.cc",
On 2016/10/07 23:06:12, msw wrote:
> Did you mean to git rm ash/mus/workspace/workspace_layout_manager_unittest.cc?
> (Also, I haven't looked closely to compare that file with the others)

Interesting enough if I git rm that file in this patch, then the diffs get
weird. See patchset 6. In particular it things the ash/common file is from the
ash/mus one. So, I'll git rm this file in the next patch.

https://codereview.chromium.org/2402643004/diff/60001/ash/wm/workspace/worksp...
File ash/wm/workspace/workspace_layout_manager_keyboard_unittest.cc (right):

https://codereview.chromium.org/2402643004/diff/60001/ash/wm/workspace/worksp...
ash/wm/workspace/workspace_layout_manager_keyboard_unittest.cc:51: class
WorkspaceLayoutManagerKeyboardTest : public AshTest {
On 2016/10/07 23:06:12, msw wrote:
> nit: add a TODO/comment about the temporary duplication and plans to
consolidate
> with the copypasta class in ash/common.

Done.

[msw, 2016-10-07 23:50:11]

lgtm

https://codereview.chromium.org/2402643004/diff/60001/ash/mus/BUILD.gn
File ash/mus/BUILD.gn (left):

https://codereview.chromium.org/2402643004/diff/60001/ash/mus/BUILD.gn#oldcod...
ash/mus/BUILD.gn:255: "workspace/workspace_layout_manager_unittest.cc",
On 2016/10/07 23:29:39, sky wrote:
> On 2016/10/07 23:06:12, msw wrote:
> > Did you mean to git rm
ash/mus/workspace/workspace_layout_manager_unittest.cc?
> > (Also, I haven't looked closely to compare that file with the others)
> 
> Interesting enough if I git rm that file in this patch, then the diffs get
> weird. See patchset 6. In particular it things the ash/common file is from the
> ash/mus one. So, I'll git rm this file in the next patch.

Acknowledged.

[sky, 2016-10-10 15:16:50]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2016-10-10 15:16:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 16:58:13]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-10-10 17:01:10]

Description was changed from

==========
Moves most of WorkspaceLayoutManagerTest into ash/common

Parts using the keyboard, which isn't refactored yet, remain in
ash/wm.

BUG=624172
TEST=test only changes
R=msw@chromium.org
==========

to

==========
Moves most of WorkspaceLayoutManagerTest into ash/common

Parts using the keyboard, which isn't refactored yet, remain in
ash/wm.

BUG=624172
TEST=test only changes
R=msw@chromium.org

Committed: https://crrev.com/9e4e404e6d5a7d5df2026dba3f17bcb6b2a6c00b
Cr-Commit-Position: refs/heads/master@{#424171}
==========

[commit-bot: I haz the power, 2016-10-10 17:01:11]

Patchset 8 (id:??) landed as
https://crrev.com/9e4e404e6d5a7d5df2026dba3f17bcb6b2a6c00b
Cr-Commit-Position: refs/heads/master@{#424171}