[wasm] Fix memory bug

[wasm] Fix memory bug

In CreateModuleObjectFromBytes, pointers to the raw bytes will be stored
inside the decoded WasmModule, and still used after allocating V8 stuff
in WasmModule::CompileFunctions. We thus cannot pass a raw pointer to
the V8 heap.
Fix this by copying the bytes before decoding.

R=mtrofin@chromium.org, titzer@chromium.org

Committed: https://crrev.com/7461fc6c2175911988accb7dccb828423d9de3e5
Cr-Commit-Position: refs/heads/master@{#40077}

[Clemens Hammacher, 2016-10-07 08:49:39]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 08:49:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 09:25:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 09:25:18]

Dry run: This issue passed the CQ dry run.

[titzer, 2016-10-07 09:29:58]

lgtm

https://codereview.chromium.org/2402633002/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2402633002/diff/1/src/api.cc#newcode7249
src/api.cc:7249: i::ScopedVector<unsigned char> bytes_copy(data->length());
Can you leave a TODO here, since we eventually make another copy of the bytes,
AFAICT.

[Clemens Hammacher, 2016-10-07 09:43:27]

https://codereview.chromium.org/2402633002/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2402633002/diff/1/src/api.cc#newcode7249
src/api.cc:7249: i::ScopedVector<unsigned char> bytes_copy(data->length());
On 2016/10/07 09:29:58, titzer wrote:
> Can you leave a TODO here, since we eventually make another copy of the bytes,
> AFAICT.

Done.

[Clemens Hammacher, 2016-10-07 09:43:49]

The CQ bit was checked by clemensh@chromium.org

[Clemens Hammacher, 2016-10-07 09:43:50]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2402633002/#ps20001
(title: "Add TODO")

[commit-bot: I haz the power, 2016-10-07 09:43:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 10:12:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-07 10:12:42]

Description was changed from

==========
[wasm] Fix memory bug

In CreateModuleObjectFromBytes, pointers to the raw bytes will be stored
inside the decoded WasmModule, and still used after allocating V8 stuff
in WasmModule::CompileFunctions. We thus cannot pass a raw pointer to
the V8 heap.
Fix this by copying the bytes before decoding.

R=mtrofin@chromium.org, titzer@chromium.org
==========

to

==========
[wasm] Fix memory bug

In CreateModuleObjectFromBytes, pointers to the raw bytes will be stored
inside the decoded WasmModule, and still used after allocating V8 stuff
in WasmModule::CompileFunctions. We thus cannot pass a raw pointer to
the V8 heap.
Fix this by copying the bytes before decoding.

R=mtrofin@chromium.org, titzer@chromium.org

Committed: https://crrev.com/7461fc6c2175911988accb7dccb828423d9de3e5
Cr-Commit-Position: refs/heads/master@{#40077}
==========

[commit-bot: I haz the power, 2016-10-07 10:12:43]

Patchset 2 (id:??) landed as
https://crrev.com/7461fc6c2175911988accb7dccb828423d9de3e5
Cr-Commit-Position: refs/heads/master@{#40077}