|
|
Created:
6 years, 8 months ago by jracle (use Gerrit) Modified:
6 years, 8 months ago Reviewers:
Ken Rockot(use gerrit already) CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
DescriptionHID : read-only device access fallback when read/write fails
- for Windows and Linux
- open device with read access when read/write fails
BUG=364438
R=rockot@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266022
Patch Set 1 #Patch Set 2 : remove un-necessary flag #
Total comments: 2
Patch Set 3 : Remove vertical whitespace #
Total comments: 2
Patch Set 4 : forgot include (Win) #Patch Set 5 : oops #
Messages
Total messages: 30 (0 generated)
The CQ bit was checked by jracle@logitech.com
The CQ bit was unchecked by jracle@logitech.com
The CQ bit was checked by jracle@logitech.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jracle@logitech.com/240263003/1
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a lowly provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a lowly provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Hi Ken, I've committed 2 patches (take #2) which aim to open access to read-only devices, e.g. consumer-control top-level collection. It is described in my document as improvement #1. Best, Julien
LGTM https://codereview.chromium.org/240263003/diff/20001/device/hid/hid_connectio... File device/hid/hid_connection_win.cc (right): https://codereview.chromium.org/240263003/diff/20001/device/hid/hid_connectio... device/hid/hid_connection_win.cc:105: DCHECK(thread_checker_.CalledOnValidThread()); nit: Remove extra vertical whitespace.
The CQ bit was checked by rockot@chromium.org
The CQ bit was unchecked by rockot@chromium.org
https://codereview.chromium.org/240263003/diff/20001/device/hid/hid_connectio... File device/hid/hid_connection_win.cc (right): https://codereview.chromium.org/240263003/diff/20001/device/hid/hid_connectio... device/hid/hid_connection_win.cc:105: DCHECK(thread_checker_.CalledOnValidThread()); sure, sorry. Thought DCHECK(...) was the only line impacted (cause it is after an opening '{')
The CQ bit was checked by rockot@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jracle@logitech.com/240263003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
https://codereview.chromium.org/240263003/diff/40001/device/hid/hid_connectio... File device/hid/hid_connection_win.cc (right): https://codereview.chromium.org/240263003/diff/40001/device/hid/hid_connectio... device/hid/hid_connection_win.cc:8: Looks like you forgot to include base/files/file.h here.
https://codereview.chromium.org/240263003/diff/40001/device/hid/hid_connectio... File device/hid/hid_connection_win.cc (right): https://codereview.chromium.org/240263003/diff/40001/device/hid/hid_connectio... device/hid/hid_connection_win.cc:8: Oops wtf
The CQ bit was checked by jracle@logitech.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jracle@logitech.com/240263003/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
The CQ bit was checked by jracle@logitech.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jracle@logitech.com/240263003/80001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
The CQ bit was checked by rockot@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jracle@logitech.com/240263003/80001
Message was sent while issue was closed.
Change committed as 266022 |