Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1156)

Issue 240263003: HID : read-only device access fallback when read/write fails (Closed)

Created:
6 years, 8 months ago by jracle (use Gerrit)
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

HID : read-only device access fallback when read/write fails - for Windows and Linux - open device with read access when read/write fails BUG=364438 R=rockot@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266022

Patch Set 1 #

Patch Set 2 : remove un-necessary flag #

Total comments: 2

Patch Set 3 : Remove vertical whitespace #

Total comments: 2

Patch Set 4 : forgot include (Win) #

Patch Set 5 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M device/hid/hid_connection_linux.cc View 1 chunk +14 lines, -2 lines 0 comments Download
M device/hid/hid_connection_win.cc View 1 2 3 4 2 chunks +12 lines, -0 lines 0 comments Download
M device/hid/hid_service_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 30 (0 generated)
jracle (use Gerrit)
The CQ bit was checked by jracle@logitech.com
6 years, 8 months ago (2014-04-17 12:57:19 UTC) #1
jracle (use Gerrit)
The CQ bit was unchecked by jracle@logitech.com
6 years, 8 months ago (2014-04-17 12:57:19 UTC) #2
jracle (use Gerrit)
The CQ bit was checked by jracle@logitech.com
6 years, 8 months ago (2014-04-17 12:59:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jracle@logitech.com/240263003/1
6 years, 8 months ago (2014-04-17 12:59:22 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-17 12:59:23 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 8 months ago (2014-04-17 12:59:23 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-17 12:59:34 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 8 months ago (2014-04-17 12:59:34 UTC) #8
jracle (use Gerrit)
Hi Ken, I've committed 2 patches (take #2) which aim to open access to read-only ...
6 years, 8 months ago (2014-04-17 13:51:10 UTC) #9
Ken Rockot(use gerrit already)
LGTM https://codereview.chromium.org/240263003/diff/20001/device/hid/hid_connection_win.cc File device/hid/hid_connection_win.cc (right): https://codereview.chromium.org/240263003/diff/20001/device/hid/hid_connection_win.cc#newcode105 device/hid/hid_connection_win.cc:105: DCHECK(thread_checker_.CalledOnValidThread()); nit: Remove extra vertical whitespace.
6 years, 8 months ago (2014-04-21 20:33:25 UTC) #10
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-04-22 23:24:41 UTC) #11
Ken Rockot(use gerrit already)
The CQ bit was unchecked by rockot@chromium.org
6 years, 8 months ago (2014-04-22 23:24:46 UTC) #12
jracle (use Gerrit)
https://codereview.chromium.org/240263003/diff/20001/device/hid/hid_connection_win.cc File device/hid/hid_connection_win.cc (right): https://codereview.chromium.org/240263003/diff/20001/device/hid/hid_connection_win.cc#newcode105 device/hid/hid_connection_win.cc:105: DCHECK(thread_checker_.CalledOnValidThread()); sure, sorry. Thought DCHECK(...) was the only line ...
6 years, 8 months ago (2014-04-23 07:38:08 UTC) #13
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-04-23 20:27:24 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jracle@logitech.com/240263003/40001
6 years, 8 months ago (2014-04-23 20:27:45 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-23 21:37:06 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-23 21:37:06 UTC) #17
Ken Rockot(use gerrit already)
https://codereview.chromium.org/240263003/diff/40001/device/hid/hid_connection_win.cc File device/hid/hid_connection_win.cc (right): https://codereview.chromium.org/240263003/diff/40001/device/hid/hid_connection_win.cc#newcode8 device/hid/hid_connection_win.cc:8: Looks like you forgot to include base/files/file.h here.
6 years, 8 months ago (2014-04-23 23:24:28 UTC) #18
jracle (use Gerrit)
https://codereview.chromium.org/240263003/diff/40001/device/hid/hid_connection_win.cc File device/hid/hid_connection_win.cc (right): https://codereview.chromium.org/240263003/diff/40001/device/hid/hid_connection_win.cc#newcode8 device/hid/hid_connection_win.cc:8: Oops wtf
6 years, 8 months ago (2014-04-24 08:30:47 UTC) #19
jracle (use Gerrit)
The CQ bit was checked by jracle@logitech.com
6 years, 8 months ago (2014-04-24 08:31:04 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jracle@logitech.com/240263003/60001
6 years, 8 months ago (2014-04-24 08:31:14 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 09:20:54 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-24 09:20:54 UTC) #23
jracle (use Gerrit)
The CQ bit was checked by jracle@logitech.com
6 years, 8 months ago (2014-04-24 10:50:41 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jracle@logitech.com/240263003/80001
6 years, 8 months ago (2014-04-24 11:03:19 UTC) #25
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 16:27:30 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-24 16:27:30 UTC) #27
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-04-24 16:40:39 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jracle@logitech.com/240263003/80001
6 years, 8 months ago (2014-04-24 16:42:22 UTC) #29
commit-bot: I haz the power
6 years, 8 months ago (2014-04-24 23:03:32 UTC) #30
Message was sent while issue was closed.
Change committed as 266022

Powered by Google App Engine
This is Rietveld 408576698