Adding encoder and decoder targets inside of //remoting/codec.

Adding encoder and decoder targets inside of //remoting/codec.

BUG=653589
R=sergeyu@chromium.org

Committed: https://crrev.com/bf3b59ec67e2904ef3932b9ff625d376c82f21a2
Cr-Commit-Position: refs/heads/master@{#424216}

[nicholss, 2016-10-07 21:43:48]

PTAL

This CL breaks apart the codec into targets that can be depended on by
themselves. So in the future we can change the client from depending on
//remoting/codec:codec to depending on just //remoting/codec:decoder if we need
to (like for iOS.)

I also removed the opus source for iOS builds inside a conditional, which might
just solve my problem outright, but still not a bad idea to have a encoder and
decoder target inside of codec.

[Sergey Ulanov, 2016-10-10 17:31:27]

lgtm

https://codereview.chromium.org/2402623003/diff/1/remoting/codec/BUILD.gn
File remoting/codec/BUILD.gn (right):

https://codereview.chromium.org/2402623003/diff/1/remoting/codec/BUILD.gn#new...
remoting/codec/BUILD.gn:65: if (is_ios) {
Add a comment here that audio_encoder_opus.cc depends on //media and //media
doesn't support iOS.

[nicholss, 2016-10-10 18:21:01]

The CQ bit was checked by nicholss@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 18:21:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 19:19:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 19:19:05]

Dry run: This issue passed the CQ dry run.

[nicholss, 2016-10-10 20:04:25]

https://codereview.chromium.org/2402623003/diff/1/remoting/codec/BUILD.gn
File remoting/codec/BUILD.gn (right):

https://codereview.chromium.org/2402623003/diff/1/remoting/codec/BUILD.gn#new...
remoting/codec/BUILD.gn:65: if (is_ios) {
On 2016/10/10 17:31:27, Sergey Ulanov wrote:
> Add a comment here that audio_encoder_opus.cc depends on //media and //media
> doesn't support iOS.

Done.

[nicholss, 2016-10-10 20:05:38]

The CQ bit was checked by nicholss@chromium.org

[nicholss, 2016-10-10 20:05:39]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/2402623003/#ps20001
(title: "Adding comment to clarify why //media is removed for iOS.")

[commit-bot: I haz the power, 2016-10-10 20:06:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 20:12:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-10 20:14:28]

Description was changed from

==========
Adding encoder and decoder targets inside of //remoting/codec.

BUG=653589

R=sergeyu@chromium.org
==========

to

==========
Adding encoder and decoder targets inside of //remoting/codec.

BUG=653589

R=sergeyu@chromium.org

Committed: https://crrev.com/bf3b59ec67e2904ef3932b9ff625d376c82f21a2
Cr-Commit-Position: refs/heads/master@{#424216}
==========

[commit-bot: I haz the power, 2016-10-10 20:14:29]

Patchset 2 (id:??) landed as
https://crrev.com/bf3b59ec67e2904ef3932b9ff625d376c82f21a2
Cr-Commit-Position: refs/heads/master@{#424216}