Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h

Issue 2402603002: State management cleanup (Closed)
Patch Set: Make state dirtying explosive Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebGL2RenderingContextBase_h 5 #ifndef WebGL2RenderingContextBase_h
6 #define WebGL2RenderingContextBase_h 6 #define WebGL2RenderingContextBase_h
7 7
8 #include "modules/webgl/WebGLExtension.h" 8 #include "modules/webgl/WebGLExtension.h"
9 #include "modules/webgl/WebGLRenderingContextBase.h" 9 #include "modules/webgl/WebGLRenderingContextBase.h"
10 #include <memory> 10 #include <memory>
(...skipping 709 matching lines...) Expand 10 before | Expand all | Expand 10 after
720 DECLARE_VIRTUAL_TRACE(); 720 DECLARE_VIRTUAL_TRACE();
721 721
722 protected: 722 protected:
723 friend class V8WebGL2RenderingContext; 723 friend class V8WebGL2RenderingContext;
724 724
725 WebGL2RenderingContextBase( 725 WebGL2RenderingContextBase(
726 HTMLCanvasElement*, 726 HTMLCanvasElement*,
727 std::unique_ptr<WebGraphicsContext3DProvider>, 727 std::unique_ptr<WebGraphicsContext3DProvider>,
728 const CanvasContextCreationAttributes& requestedAttributes); 728 const CanvasContextCreationAttributes& requestedAttributes);
729 729
730 // DrawingBufferRestoreStateSource implementation.
731 void GetDrawingBufferRestoreState(DrawingBufferRestoreState*) override;
732
730 // Helper function to validate target and the attachment combination for 733 // Helper function to validate target and the attachment combination for
731 // getFramebufferAttachmentParameters. Generate GL error and return false if 734 // getFramebufferAttachmentParameters. Generate GL error and return false if
732 // parameters are illegal. 735 // parameters are illegal.
733 bool validateGetFramebufferAttachmentParameterFunc(const char* functionName, 736 bool validateGetFramebufferAttachmentParameterFunc(const char* functionName,
734 GLenum target, 737 GLenum target,
735 GLenum attachment); 738 GLenum attachment);
736 739
737 bool validateClearBuffer(const char* functionName, 740 bool validateClearBuffer(const char* functionName,
738 GLenum buffer, 741 GLenum buffer,
739 GLsizei length); 742 GLsizei length);
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
866 context, 869 context,
867 context->is3d() && 870 context->is3d() &&
868 WebGLRenderingContextBase::getWebGLVersion(context) >= 2, 871 WebGLRenderingContextBase::getWebGLVersion(context) >= 2,
869 context.is3d() && 872 context.is3d() &&
870 WebGLRenderingContextBase::getWebGLVersion(&context) >= 873 WebGLRenderingContextBase::getWebGLVersion(&context) >=
871 2); 874 2);
872 875
873 } // namespace blink 876 } // namespace blink
874 877
875 #endif 878 #endif
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698