Files.app: Introduce TestEntryInfo class to JavaScript code.

chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
+ * @enum {string}
+ * @const
+ */
+var EntryType = {

[yoshiki, 2013/09/10 04:38:55]

Object.freeze?

[hirono, 2013/09/10 04:56:02]

Done.

+  FILE: 'file',
+  DIRECTORY: 'directory'
+};
+
+/**
+ * @enum {string}
+ * @const
+ */
+var SharedOption = {

[yoshiki, 2013/09/10 04:38:55]

ditto

[hirono, 2013/09/10 04:56:02]

Done.

+  NONE: 'none',
+  SHARED: 'shared'
+};
+
+
+/**
+ * File system entry information for tests.
+ *
+ * @param {EntryType} entryType Entry type.
+ * @param {string} sourceFileName Source file name that provides file contents.
+ * @param {string} targetName Name of entry on the test file system.
+ * @param {string} mimeType Mime type.
+ * @param {string} typeText Type name to be shown in the type column.
+ * @param {string} sizeText Size text to be shown in the size column.
+ * @param {SharedOption} sharedOption Shared option.
+ * @param {string} lastModifiedTime Last modified time as a text to be shown in
+ *     the last modified column.
+ * @constructor
+ */
+var TestEntryInfo = function(entryType,
+                             sourceFileName,
+                             targetName,
+                             mimeType,
+                             typeText,
+                             sizeText,
+                             sharedOption,
+                             lastModifiedTime) {
+  this.entryType = entryType;
+  this.sourceFileName = sourceFileName;
+  this.targetName = targetName;
+  this.mimeType = mimeType;
+  this.typeText = typeText;
+  this.sizeText = sizeText;
+  this.sharedOption = sharedOption;
+  this.lastModifiedTime = lastModifiedTime;
+};

[yoshiki, 2013/09/10 04:38:55]

Object.seal(this)?

[hirono, 2013/09/10 04:56:02]

This object is immutable, so we can freeze this.

+
+/**
+ * Obtains a expected row contents of the file in the file list.
+ */
+TestEntryInfo.prototype.getExpectedRow = function() {
+  return [this.targetName, this.sizeText, this.typeText, this.lastModifiedTime];
+};
+
+/**
  * Expected files before tests are performed. Entries for Local tests.
  * @type {Array.<Array.<string>>}
  * @const
  */
 var EXPECTED_FILES_BEFORE_LOCAL = [
   ['hello.txt', '51 bytes', 'Plain text', 'Sep 4, 1998 12:34 PM'],
   ['world.ogv', '59 KB', 'OGG video', 'Jul 4, 2012 10:35 AM'],
   ['My Desktop Background.png', '272 bytes', 'PNG image',
       'Jan 18, 2038 1:02 AM'],
   ['Beautiful Song.ogg', '14 KB', 'OGG audio', 'Nov 12, 2086 12:00 PM'],
@@ skipping 11 matching lines @@
   ['world.ogv', '59 KB', 'OGG video', 'Jul 4, 2012 10:35 AM'],
   ['My Desktop Background.png', '272 bytes', 'PNG image',
       'Jan 18, 2038 1:02 AM'],
   ['Beautiful Song.ogg', '14 KB', 'OGG audio', 'Nov 12, 2086 12:00 PM'],
   ['photos', '--', 'Folder', 'Jan 1, 1980 11:59 PM'],
   ['Test Document.gdoc','--','Google document','Apr 10, 2013 4:20 PM'],
   ['Test Shared Document.gdoc','--','Google document','Mar 20, 2013 10:40 PM']
 ].sort();
 
 /**
- * Expected files added during some tests.
- * @type {Array.<Array.<string>>}
+ * Filesystem entries used by the test cases.
+ * @type {Object.<string, TestEntryInfo>}
  * @const
  */
-var EXPECTED_NEWLY_ADDED_FILE = [
-  ['newly added file.ogg', '14 KB', 'OGG audio', 'Sep 4, 1998 12:00 AM']
-];
+var ENTRIES = {
+  newlyAdded: new TestEntryInfo(
+      EntryType.FILE, 'music.ogg', 'newly added file.ogg',
+      'audio/ogg', 'OGG audio', '14 KB', SharedOption.NONE,
+      'Sep 4, 1998 12:00 AM')
+};
 
 /**
  * @param {boolean} isDrive True if the test is for Drive.
  * @return {Array.<Array.<string>>} A sorted list of expected entries at the
  *     initial state.
  */
 function getExpectedFilesBefore(isDrive) {
   return isDrive ?
       EXPECTED_FILES_BEFORE_DRIVE :
       EXPECTED_FILES_BEFORE_LOCAL;
@@ skipping 105 matching lines @@
  * Tests if the files initially added by the C++ side are displayed, and
  * that a subsequently added file shows up.
  *
  * @param {string} path Directory path to be tested.
  */
 testcase.intermediate.fileDisplay = function(path) {
   var appId;
 
   var expectedFilesBefore = getExpectedFilesBefore(path == '/drive/root');
   var expectedFilesAfter =
-      expectedFilesBefore.concat(EXPECTED_NEWLY_ADDED_FILE).sort();
+      expectedFilesBefore.concat([ENTRIES.newlyAdded.getExpectedRow()]).sort();
 
   StepsRunner.run([
     function() {
       setupAndWaitUntilReady(path, this.next);
     },
     // Notify that the list has been verified and a new file can be added
     // in file_manager_browsertest.cc.
     function(inAppId, actualFilesBefore) {
       appId = inAppId;
       chrome.test.assertEq(expectedFilesBefore, actualFilesBefore);
-      addEntries(['local', 'drive'], [{
-        type: 'file',
-        source_file_name: 'music.ogg',
-        target_name: 'newly added file.ogg',
-        mime_type: 'audio/ogg',
-        shared_option: 'none',
-        last_modified_time: '4 Sep 1998 00:00:00'
-      }], this.next);
+      addEntries(['local', 'drive'], [ENTRIES.newlyAdded], this.next);
     },
     function(result) {
       chrome.test.assertTrue(result);
       callRemoteTestUtil(
           'waitForFileListChange',
           appId,
           [expectedFilesBefore.length],
           this.next);
     },
     // Confirm the file list.
@@ skipping 1016 matching lines @@
                          appId2,
                          [650, 490],
                          this.next);
     },
     // Check for errors.
     function() {
       checkIfNoErrorsOccured(this.next);
     }
   ]);
 };